tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9edc472eaf
memgraph/tests/unit
History
florijan 9edc472eaf Resolving TODOs in the operator implementations 
Summary:
Three TODOs resolved.

1. around line 897 - we currently don't support expansion into existing variable length edges (there is a TODO in symbol_generator.cpp:213), so this should not be done at the moment.

2. around line 1025 - This TODO was on review and nobody commented, so I'm removing it. Should have done that when the diff landed.

3. around line 1560 - This does not seem possible. Edge-uniqueness checks happen within a single `[OPTIONAL ] MATCH`. If it is OPTIONAL (the case interesting here), then the uniqueness check also gets planned under the optional branch. So, if an optional fails, the uniqueness check will get skipped, as opposed to getting executed over a Null. I added an edge-case test to verify this (and checked with the planner test).

Reviewers: buda, teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D807
2017-09-19 09:48:28 +02:00
..
bolt_buffer.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
bolt_chunked_decoder_buffer.cpp Fixed bolt decoder chunked buffer implementation. 2017-09-06 13:19:42 +02:00
bolt_chunked_encoder_buffer.cpp Fixed bolt chunked encoder buffer for big data. 2017-09-06 15:36:24 +02:00
bolt_common.hpp Removed Dbms and QueryEngine from the Network stack. 2017-08-03 16:33:10 +02:00
bolt_decoder.cpp First version of bolt cpp client. 2017-08-24 17:44:44 +02:00
bolt_encoder.cpp GraphDbAccessor - style change 2017-08-09 16:09:08 +02:00
bolt_result_stream.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
bolt_session.cpp Fixed bolt decoder chunked buffer implementation. 2017-09-06 13:19:42 +02:00
bolt_testdata.hpp Removed large bolt encoder test to reduce runtime. 2017-05-03 14:50:02 +02:00
CMakeLists.txt Folder rename. 2017-07-21 09:50:30 +02:00
concurrent_list.cpp clang format has been run on all hpp and cpp files under src and tests 2017-02-18 11:54:37 +01:00
concurrent_map.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
concurrent_set.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
cypher_main_visitor.cpp Generate ParameterLookup instead of PrimitiveLiteral 2017-09-13 17:49:34 +02:00
database_key_index.cpp GraphDbAccessor - style change 2017-08-09 16:09:08 +02:00
database_label_property_index.cpp GraphDbAccessor - style change 2017-08-09 16:09:08 +02:00
database_transaction_timeout.cpp Add query parameters support 2017-07-19 18:44:59 +02:00
dbms_recovery.cpp GraphDbAccessor - style change 2017-08-09 16:09:08 +02:00
deferred_deleter.cpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
dynamic_bitset.cpp Fix tests that expect debug_assert to fail 2017-08-07 16:38:15 +02:00
exceptions.cpp Merge utils/exceptions into single file 2017-04-20 16:53:21 +02:00
executor.cpp Rename Executioner to Executor 2017-09-07 15:13:17 +02:00
fswatcher.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
graph_db_accessor_index_api.cpp Property storage now supports Map 2017-08-24 10:29:49 +02:00
graph_db_accessor.cpp Remove rand from dba 2017-08-29 12:28:32 +02:00
graph_db.cpp GraphDb - index garbage collection fix 2017-08-17 09:14:00 +02:00
mvcc_find_update_common.hpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
mvcc_find.cpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
mvcc_gc_common.hpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
mvcc_gc.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
mvcc_one_transaction.cpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
mvcc_parallel_update.cpp Added mvcc tests with one transaction and modified version list update function 2017-06-02 07:37:42 +00:00
mvcc.cpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
network_endpoint.cpp Started network refactorization. 2017-03-06 13:52:34 +01:00
property_value_store.cpp PropertyValueStore - remove Accept function (never used, never will be) 2017-09-13 10:11:55 +02:00
query_common.hpp Named path support 2017-09-19 09:45:50 +02:00
query_cost_estimator.cpp Look into parameter value when estimating plan cost 2017-09-15 16:14:57 +02:00
query_engine.cpp Add BFS integration test 2017-08-22 17:58:42 +02:00
query_expression_evaluator.cpp Named path support 2017-09-19 09:45:50 +02:00
query_plan_accumulate_aggregate.cpp Use EdgeType in Expand and ExpandVariable 2017-09-11 11:16:04 +02:00
query_plan_bag_semantics.cpp GraphDbAccessor - style change 2017-08-09 16:09:08 +02:00
query_plan_common.hpp Add ParameterLookup to AST 2017-09-13 14:28:48 +02:00
query_plan_create_set_remove_delete.cpp Add ParameterLookup to AST 2017-09-13 14:28:48 +02:00
query_plan_edge_cases.cpp Resolving TODOs in the operator implementations 2017-09-19 09:48:28 +02:00
query_plan_match_filter_return.cpp Named path support 2017-09-19 09:45:50 +02:00
query_planner.cpp Named path support 2017-09-19 09:45:50 +02:00
query_semantic.cpp Named path support 2017-09-19 09:45:50 +02:00
query_variable_start_planner.cpp Add filtering BFS by edge type 2017-09-12 11:29:38 +02:00
record_edge_vertex_accessor.cpp Vertex edges data structure introduced 2017-09-08 13:21:21 +02:00
recovery.cpp unit.recovery: Read vertex IDs into int64_t, not int 2017-09-09 09:24:42 +02:00
scheduler.cpp Scheduler - removed templatization 2017-08-17 16:10:41 +02:00
signal_handler.cpp Reorganize logging in memgraph_bolt.cpp 2017-06-14 10:11:31 +02:00
skiplist_gc.cpp Use GLogger instead of broken memgraph Logger. 2017-06-21 15:33:24 +02:00
skiplist_position_and_count.cpp Skiplist::position_and_count fix 2017-08-03 14:57:11 +02:00
skiplist_reverse_iteration.cpp Logger in this test somehow breaks code coverage. Argh... 2017-04-07 09:44:12 +02:00
skiplist_suffix.cpp Rework of index api. Remove implicit default value of current_state in graph_db_accessor. 2017-06-07 10:14:55 +02:00
snapshot.cpp Move dbms to database 2017-07-12 12:44:11 +02:00
static_bitset.cpp Fix tests that expect debug_assert to fail 2017-08-07 16:38:15 +02:00
stripped.cpp Parse utf16 surrogate codepoints correctly 2017-09-04 16:03:45 +02:00
timestamp.cpp all unit tests are gtests 2017-02-19 23:47:09 +01:00
transaction_engine.cpp GC bugfixes, MVCC and transaction refactoring 2017-06-12 10:46:12 +02:00
traversal.cpp Fix warnings all over the codebase. 2017-03-22 09:32:06 +01:00
typed_value.cpp Named path support 2017-09-19 09:45:50 +02:00
unique_object_store.cpp clang format has been run on all hpp and cpp files under src and tests 2017-02-18 11:54:37 +01:00
utils_on_scope_exit.cpp utils::auto_scope refactor 2017-08-11 09:43:10 +02:00