c09b175c76
* [T1006-MG < T1017-MG] Add LBA checks to all read procedures in C API (#515) * Initial Impl * NextPermittedEdge introduced * revert moving constructor to cpp * edge from and edge to methods expanded with lba check * minor fix * added check to path expand procedure * Added integration tests for read query procedures * additional check * changed iterator type to reference * comments from pr Co-authored-by: Josip Mrden <josip.mrden@memgraph.io> * [T1006-MG < T1018-MG] Add LBA checks to all update procedures in C API (#516) * Initial Impl * NextPermittedEdge introduced * revert moving constructor to cpp * edge from and edge to methods expanded with lba check * minor fix * extended update methods * added check to path expand procedure * Added integration tests for read query procedures * Added integration tests for update query modules * additional check * changed iterator type to reference * fixed bug in Update property for node; fixed 2 e2e tests * replaced enum Co-authored-by: Josip Mrden <josip.mrden@memgraph.io> * [T1006-MG < T1019-MG] Add LBA checks to all Create and Delete procedures in C API (#517) * Initial Impl * NextPermittedEdge introduced * revert moving constructor to cpp * edge from and edge to methods expanded with lba check * minor fix * extended update methods * initial implementation * added check to path expand procedure * Added integration tests for read query procedures * Added integration tests for update query modules * Added unit tests for creation of vertex, adding and removing vertex label * additional check * changed iterator type to reference * Added unit tests for create edge * Corrected query module in create edge * fixed bug in Update property for node; fixed 2 e2e tests * fixed merge errors * Expanded FineGrainedAuthChecker with HasGlobalPermissionOnVertices and HasGlobalPermissionOnEdges * Removed two wrong checks; Added two global checks * return null added * introduced new mgp_error value * fixed endless loop * replaced enum * intermediate * tests updated * PermissionDeniedError -> AuthorizationError rename * rename in enum permission_denied error -> authorization error * mgp_vertex_remove_label check improved * quotes changed; order of imports fixed * string constant introduced * import fixed * yaml format Co-authored-by: Josip Mrden <josip.mrden@memgraph.io> Co-authored-by: Josip Mrden <josip.mrden@memgraph.io>
163 lines
5.5 KiB
Python
163 lines
5.5 KiB
Python
# Copyright 2022 Memgraph Ltd.
|
|
#
|
|
# Use of this software is governed by the Business Source License
|
|
# included in the file licenses/BSL.txt; by using this file, you agree to be bound by the terms of the Business Source
|
|
# License, and you may not use this file except in compliance with the Business Source License.
|
|
#
|
|
# As of the Change Date specified in that file, in accordance with
|
|
# the Business Source License, use of this software will be governed
|
|
# by the Apache License, Version 2.0, included in the file
|
|
# licenses/APL.txt.
|
|
|
|
import pytest
|
|
import sys
|
|
|
|
from typing import List
|
|
|
|
from common import connect, execute_and_fetch_all, reset_permissions
|
|
|
|
match_query = "MATCH (n) RETURN n;"
|
|
match_by_id_query = "MATCH (n) WHERE ID(n) >= 0 RETURN n;"
|
|
|
|
match_by_label_query = "MATCH (n) RETURN n;"
|
|
match_by_label_property_range_query = "MATCH (n) WHERE n.prop < 7 RETURN n;"
|
|
match_by_label_property_value_query = "MATCH (n {prop: 5}) RETURN n;"
|
|
match_by_label_property_query = "MATCH (n) WHERE n.prop IS NOT NULL RETURN n;"
|
|
|
|
|
|
read_node_without_index_operation_cases = [
|
|
["GRANT READ ON LABELS :read_label TO user;"],
|
|
["GRANT READ ON LABELS * TO user;"],
|
|
["GRANT UPDATE ON LABELS :read_label TO user;"],
|
|
["GRANT UPDATE ON LABELS * TO user;"],
|
|
["GRANT CREATE_DELETE ON LABELS :read_label TO user;"],
|
|
["GRANT CREATE_DELETE ON LABELS * TO user;"],
|
|
]
|
|
|
|
read_node_without_index_operation_cases_expected_size = [1, 3, 1, 3, 1, 3]
|
|
|
|
read_node_with_index_operation_cases = [
|
|
["GRANT READ ON LABELS :read_label TO user;"],
|
|
["GRANT READ ON LABELS * TO user;"],
|
|
["GRANT UPDATE ON LABELS :read_label TO user;"],
|
|
["GRANT UPDATE ON LABELS * TO user;"],
|
|
["GRANT CREATE_DELETE ON LABELS :read_label TO user;"],
|
|
["GRANT CREATE_DELETE ON LABELS * TO user;"],
|
|
]
|
|
|
|
read_node_with_index_operation_cases_expected_sizes = [1, 3, 1, 3, 1, 3]
|
|
|
|
not_read_node_without_index_operation_cases = [
|
|
[],
|
|
["DENY READ ON LABELS :read_label TO user;"],
|
|
["DENY READ ON LABELS * TO user;"],
|
|
[
|
|
"GRANT UPDATE ON LABELS :read_label TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
[
|
|
"GRANT UPDATE ON LABELS * TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
[
|
|
"GRANT CREATE_DELETE ON LABELS :read_label TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
[
|
|
"GRANT CREATE_DELETE ON LABELS * TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
]
|
|
|
|
not_read_node_without_index_operation_cases_expected_sizes = [0, 0, 0, 0, 2, 0, 2]
|
|
|
|
not_read_node_with_index_operation_cases = [
|
|
[],
|
|
["DENY READ ON LABELS :read_label TO user;"],
|
|
["DENY READ ON LABELS * TO user;"],
|
|
[
|
|
"GRANT UPDATE ON LABELS :read_label TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
[
|
|
"GRANT UPDATE ON LABELS * TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
[
|
|
"GRANT CREATE_DELETE ON LABELS :read_label TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
[
|
|
"GRANT CREATE_DELETE ON LABELS * TO user;",
|
|
"DENY READ ON LABELS :read_label TO user",
|
|
],
|
|
]
|
|
|
|
not_read_node_with_index_operation_cases_expexted_sizes = [0, 0, 0, 0, 2, 0, 2]
|
|
|
|
|
|
def get_admin_cursor():
|
|
return connect(username="admin", password="test").cursor()
|
|
|
|
|
|
def get_user_cursor():
|
|
return connect(username="user", password="test").cursor()
|
|
|
|
|
|
def execute_read_node_assertion(
|
|
operation_case: List[str], queries: List[str], create_index: bool, expected_size: int
|
|
) -> None:
|
|
admin_cursor = get_admin_cursor()
|
|
user_cursor = get_user_cursor()
|
|
|
|
reset_permissions(admin_cursor, create_index)
|
|
|
|
for operation in operation_case:
|
|
execute_and_fetch_all(admin_cursor, operation)
|
|
|
|
for mq in queries:
|
|
results = execute_and_fetch_all(user_cursor, mq)
|
|
assert len(results) == expected_size
|
|
|
|
|
|
def test_can_read_node_when_authorized():
|
|
match_queries_without_index = [match_query, match_by_id_query]
|
|
match_queries_with_index = [
|
|
match_by_label_query,
|
|
match_by_label_property_query,
|
|
match_by_label_property_range_query,
|
|
match_by_label_property_value_query,
|
|
]
|
|
|
|
for expected_size, operation_case in zip(
|
|
read_node_without_index_operation_cases_expected_size, read_node_without_index_operation_cases
|
|
):
|
|
execute_read_node_assertion(operation_case, match_queries_without_index, False, expected_size)
|
|
for expected_size, operation_case in zip(
|
|
read_node_with_index_operation_cases_expected_sizes, read_node_with_index_operation_cases
|
|
):
|
|
execute_read_node_assertion(operation_case, match_queries_with_index, True, expected_size)
|
|
|
|
|
|
def test_can_not_read_node_when_authorized():
|
|
match_queries_without_index = [match_query, match_by_id_query]
|
|
match_queries_with_index = [
|
|
match_by_label_query,
|
|
match_by_label_property_query,
|
|
match_by_label_property_range_query,
|
|
match_by_label_property_value_query,
|
|
]
|
|
|
|
for expected_size, operation_case in zip(
|
|
not_read_node_without_index_operation_cases_expected_sizes, not_read_node_without_index_operation_cases
|
|
):
|
|
execute_read_node_assertion(operation_case, match_queries_without_index, False, expected_size)
|
|
for expected_size, operation_case in zip(
|
|
not_read_node_with_index_operation_cases_expexted_sizes, not_read_node_with_index_operation_cases
|
|
):
|
|
execute_read_node_assertion(operation_case, match_queries_with_index, True, expected_size)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(pytest.main([__file__, "-rA"]))
|