0a6b8cdf4f
Summary: Removing `AS_IS` from GraphView because it doesn't seem like it is necessary for query execution and it also has weird semantics (you might get a mix of old and new records). `Unwind`, `OrderBy` and `PullRemoteOrderBy` now use `OLD` graph view. Remove AS_IS from GraphView Fix query_cost_estimator tests Fix query_expression_evaluator tests Fix query_plan_match_filter_return tests Fix query_plan_create_set_remove_delete tests Fix query_plan_accumulate_aggregate tests Reviewers: teon.banek, buda Reviewed By: teon.banek Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D1390
220 lines
7.9 KiB
C++
220 lines
7.9 KiB
C++
#include <gtest/gtest.h>
|
|
#include <memory>
|
|
|
|
#include "query/frontend/ast/ast.hpp"
|
|
#include "query/frontend/semantic/symbol_table.hpp"
|
|
#include "query/plan/cost_estimator.hpp"
|
|
#include "query/plan/operator.hpp"
|
|
#include "storage/vertex_accessor.hpp"
|
|
|
|
using namespace query;
|
|
using namespace query::plan;
|
|
|
|
using CardParam = CostEstimator<database::GraphDbAccessor>::CardParam;
|
|
using CostParam = CostEstimator<database::GraphDbAccessor>::CostParam;
|
|
using MiscParam = CostEstimator<database::GraphDbAccessor>::MiscParam;
|
|
|
|
/** A fixture for cost estimation. Sets up the database
|
|
* and accessor (adds some vertices). Provides convenience
|
|
* functions for creating the logical plan. Note that the
|
|
* resulting plan is NOT fit for execution, only for cost
|
|
* estimation testing. */
|
|
class QueryCostEstimator : public ::testing::Test {
|
|
protected:
|
|
database::SingleNode db;
|
|
std::experimental::optional<database::GraphDbAccessor> dba{db};
|
|
storage::Label label = dba->Label("label");
|
|
storage::Property property = dba->Property("property");
|
|
|
|
// we incrementally build the logical operator plan
|
|
// start it off with Once
|
|
std::shared_ptr<LogicalOperator> last_op_ = std::make_shared<Once>();
|
|
|
|
AstTreeStorage storage_;
|
|
SymbolTable symbol_table_;
|
|
Parameters parameters_;
|
|
int symbol_count = 0;
|
|
|
|
void SetUp() {
|
|
// create the index in the current db accessor and then swap it to a new one
|
|
dba->BuildIndex(label, property);
|
|
dba.emplace(db);
|
|
}
|
|
|
|
Symbol NextSymbol() {
|
|
return symbol_table_.CreateSymbol("Symbol" + std::to_string(symbol_count++),
|
|
true);
|
|
}
|
|
|
|
/** Adds the given number of vertices to the DB, of which
|
|
* the given numbers are labeled and have a property set. */
|
|
void AddVertices(int vertex_count, int labeled_count,
|
|
int property_count = 0) {
|
|
for (int i = 0; i < vertex_count; i++) {
|
|
auto vertex = dba->InsertVertex();
|
|
if (i < labeled_count) vertex.add_label(label);
|
|
if (i < property_count) vertex.PropsSet(property, i);
|
|
}
|
|
|
|
dba->AdvanceCommand();
|
|
}
|
|
|
|
auto Cost() {
|
|
CostEstimator<database::GraphDbAccessor> cost_estimator(*dba, parameters_);
|
|
last_op_->Accept(cost_estimator);
|
|
return cost_estimator.cost();
|
|
}
|
|
|
|
template <typename TLogicalOperator, typename... TArgs>
|
|
void MakeOp(TArgs... args) {
|
|
last_op_ = std::make_shared<TLogicalOperator>(args...);
|
|
}
|
|
|
|
template <typename TValue>
|
|
Expression *Literal(TValue value) {
|
|
return storage_.Create<PrimitiveLiteral>(value);
|
|
}
|
|
|
|
Expression *Parameter(const TypedValue &value) {
|
|
int token_position = parameters_.size();
|
|
parameters_.Add(token_position, value);
|
|
return storage_.Create<ParameterLookup>(token_position);
|
|
}
|
|
|
|
auto InclusiveBound(Expression *expression) {
|
|
return std::experimental::make_optional(
|
|
utils::MakeBoundInclusive(expression));
|
|
};
|
|
|
|
const std::experimental::nullopt_t nullopt = std::experimental::nullopt;
|
|
};
|
|
|
|
// multiply with 1 to avoid linker error (possibly fixed in CLang >= 3.81)
|
|
#define EXPECT_COST(COST) EXPECT_FLOAT_EQ(Cost(), 1 * COST)
|
|
|
|
TEST_F(QueryCostEstimator, Once) { EXPECT_COST(0); }
|
|
|
|
TEST_F(QueryCostEstimator, ScanAll) {
|
|
AddVertices(100, 30, 20);
|
|
MakeOp<ScanAll>(last_op_, NextSymbol());
|
|
EXPECT_COST(100 * CostParam::kScanAll);
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ScanAllByLabelCardinality) {
|
|
AddVertices(100, 30, 20);
|
|
MakeOp<ScanAllByLabel>(last_op_, NextSymbol(), label);
|
|
EXPECT_COST(30 * CostParam::kScanAllByLabel);
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ScanAllByLabelPropertyValueConstant) {
|
|
AddVertices(100, 30, 20);
|
|
for (auto const_val : {Literal(12), Parameter(12)}) {
|
|
MakeOp<ScanAllByLabelPropertyValue>(nullptr, NextSymbol(), label, property,
|
|
const_val);
|
|
EXPECT_COST(1 * CostParam::MakeScanAllByLabelPropertyValue);
|
|
}
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ScanAllByLabelPropertyValueConstExpr) {
|
|
AddVertices(100, 30, 20);
|
|
for (auto const_val : {Literal(12), Parameter(12)}) {
|
|
MakeOp<ScanAllByLabelPropertyValue>(
|
|
nullptr, NextSymbol(), label, property,
|
|
// once we make expression const-folding this test case will fail
|
|
storage_.Create<UnaryPlusOperator>(const_val));
|
|
EXPECT_COST(20 * CardParam::kFilter *
|
|
CostParam::MakeScanAllByLabelPropertyValue);
|
|
}
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ScanAllByLabelPropertyRangeUpperConstant) {
|
|
AddVertices(100, 30, 20);
|
|
for (auto const_val : {Literal(12), Parameter(12)}) {
|
|
MakeOp<ScanAllByLabelPropertyRange>(nullptr, NextSymbol(), label, property,
|
|
nullopt, InclusiveBound(const_val));
|
|
// cardinality estimation is exact for very small indexes
|
|
EXPECT_COST(13 * CostParam::MakeScanAllByLabelPropertyRange);
|
|
}
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ScanAllByLabelPropertyRangeLowerConstant) {
|
|
AddVertices(100, 30, 20);
|
|
for (auto const_val : {Literal(17), Parameter(17)}) {
|
|
MakeOp<ScanAllByLabelPropertyRange>(nullptr, NextSymbol(), label, property,
|
|
InclusiveBound(const_val), nullopt);
|
|
// cardinality estimation is exact for very small indexes
|
|
EXPECT_COST(3 * CostParam::MakeScanAllByLabelPropertyRange);
|
|
}
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ScanAllByLabelPropertyRangeConstExpr) {
|
|
AddVertices(100, 30, 20);
|
|
for (auto const_val : {Literal(12), Parameter(12)}) {
|
|
auto bound = std::experimental::make_optional(
|
|
utils::MakeBoundInclusive(static_cast<Expression *>(
|
|
storage_.Create<UnaryPlusOperator>(const_val))));
|
|
MakeOp<ScanAllByLabelPropertyRange>(nullptr, NextSymbol(), label, property,
|
|
bound, nullopt);
|
|
EXPECT_COST(20 * CardParam::kFilter *
|
|
CostParam::MakeScanAllByLabelPropertyRange);
|
|
}
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, Expand) {
|
|
MakeOp<Expand>(NextSymbol(), NextSymbol(), EdgeAtom::Direction::IN,
|
|
std::vector<storage::EdgeType>{}, last_op_, NextSymbol(),
|
|
false, GraphView::OLD);
|
|
EXPECT_COST(CardParam::kExpand * CostParam::kExpand);
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ExpandVariable) {
|
|
MakeOp<ExpandVariable>(
|
|
NextSymbol(), NextSymbol(), EdgeAtom::Type::DEPTH_FIRST,
|
|
EdgeAtom::Direction::IN, std::vector<storage::EdgeType>{}, false, nullptr,
|
|
nullptr, last_op_, NextSymbol(), false,
|
|
ExpandVariable::Lambda{NextSymbol(), NextSymbol(), nullptr},
|
|
std::experimental::nullopt, std::experimental::nullopt, GraphView::OLD);
|
|
EXPECT_COST(CardParam::kExpandVariable * CostParam::kExpandVariable);
|
|
}
|
|
|
|
// Helper for testing an operations cost and cardinality.
|
|
// Only for operations that first increment cost, then modify cardinality.
|
|
// Intentially a macro (instead of function) for better test feedback.
|
|
#define TEST_OP(OP, OP_COST_PARAM, OP_CARD_PARAM) \
|
|
OP; \
|
|
EXPECT_COST(OP_COST_PARAM); \
|
|
OP; \
|
|
EXPECT_COST(OP_COST_PARAM + OP_CARD_PARAM * OP_COST_PARAM);
|
|
|
|
TEST_F(QueryCostEstimator, Filter) {
|
|
TEST_OP(MakeOp<Filter>(last_op_, Literal(true)), CostParam::kFilter,
|
|
CardParam::kFilter);
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, ExpandUniquenessFilter) {
|
|
TEST_OP(MakeOp<ExpandUniquenessFilter<VertexAccessor>>(last_op_, NextSymbol(),
|
|
std::vector<Symbol>()),
|
|
CostParam::kExpandUniquenessFilter,
|
|
CardParam::kExpandUniquenessFilter);
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, UnwindLiteral) {
|
|
TEST_OP(
|
|
MakeOp<query::plan::Unwind>(
|
|
last_op_,
|
|
storage_.Create<ListLiteral>(std::vector<Expression *>(7, nullptr)),
|
|
NextSymbol()),
|
|
CostParam::kUnwind, 7);
|
|
}
|
|
|
|
TEST_F(QueryCostEstimator, UnwindNoLiteral) {
|
|
TEST_OP(MakeOp<query::plan::Unwind>(last_op_, nullptr, NextSymbol()),
|
|
CostParam::kUnwind, MiscParam::kUnwindNoLiteral);
|
|
}
|
|
|
|
#undef TEST_OP
|
|
#undef EXPECT_COST
|
|
//
|
|
// TODO test cost when ScanAll, Expand, Accumulate, Limit
|
|
// vs cost for SA, Expand, Limit
|