9f460914ed
Summary: GraphDbAccessor is now constructed only through GraphDb. This allows the concrete GraphDb to instantiate a concrete GraphDbAccessor. This allows us to use virtual calls, so that the implementation may be kept separate. The major downside of doing things this way is heap allocation of GraphDbAccessor. In case it turns out to be a real performance issues, another solution with pointer to static implementation may be used. InsertVertexIntoRemote is now a non-member function, which reduces coupling. It made no sense for it to be member function because it used only the public parts of GraphDbAccessor. Reviewers: msantl, mtomic, mferencevic Reviewed By: msantl Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D1504
139 lines
4.3 KiB
C++
139 lines
4.3 KiB
C++
#include <unordered_map>
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "database/graph_db_accessor.hpp"
|
|
#include "storage/edge_accessor.hpp"
|
|
#include "storage/vertex_accessor.hpp"
|
|
|
|
#include "distributed_common.hpp"
|
|
|
|
using namespace database;
|
|
using namespace std::literals::chrono_literals;
|
|
|
|
class DistributedDataExchangeTest : public DistributedGraphDbTest {
|
|
public:
|
|
DistributedDataExchangeTest() : DistributedGraphDbTest("data_exchange") {}
|
|
};
|
|
|
|
TEST_F(DistributedDataExchangeTest, RemoteDataGetting) {
|
|
// Only old data is visible remotely, so create and commit some data.
|
|
gid::Gid v1_id, v2_id, e1_id;
|
|
|
|
{
|
|
auto dba = master().Access();
|
|
auto v1 = dba->InsertVertex();
|
|
auto v2 = dba->InsertVertex();
|
|
auto e1 = dba->InsertEdge(v1, v2, dba->EdgeType("et"));
|
|
|
|
// Set some data so we see we're getting the right stuff.
|
|
v1.PropsSet(dba->Property("p1"), 42);
|
|
v1.add_label(dba->Label("label"));
|
|
v2.PropsSet(dba->Property("p2"), "value");
|
|
e1.PropsSet(dba->Property("p3"), true);
|
|
|
|
v1_id = v1.gid();
|
|
v2_id = v2.gid();
|
|
e1_id = e1.gid();
|
|
|
|
dba->Commit();
|
|
}
|
|
|
|
// The master must start a transaction before workers can work in it.
|
|
auto master_dba = master().Access();
|
|
|
|
{
|
|
auto w1_dba = worker(1).Access(master_dba->transaction_id());
|
|
VertexAccessor v1_in_w1{{v1_id, 0}, *w1_dba};
|
|
EXPECT_NE(v1_in_w1.GetOld(), nullptr);
|
|
EXPECT_EQ(v1_in_w1.GetNew(), nullptr);
|
|
EXPECT_EQ(v1_in_w1.PropsAt(w1_dba->Property("p1")).Value<int64_t>(), 42);
|
|
EXPECT_TRUE(v1_in_w1.has_label(w1_dba->Label("label")));
|
|
}
|
|
|
|
{
|
|
auto w2_dba = worker(2).Access(master_dba->transaction_id());
|
|
VertexAccessor v2_in_w2{{v2_id, 0}, *w2_dba};
|
|
EXPECT_NE(v2_in_w2.GetOld(), nullptr);
|
|
EXPECT_EQ(v2_in_w2.GetNew(), nullptr);
|
|
EXPECT_EQ(v2_in_w2.PropsAt(w2_dba->Property("p2")).Value<std::string>(),
|
|
"value");
|
|
EXPECT_FALSE(v2_in_w2.has_label(w2_dba->Label("label")));
|
|
|
|
VertexAccessor v1_in_w2{{v1_id, 0}, *w2_dba};
|
|
EdgeAccessor e1_in_w2{{e1_id, 0}, *w2_dba};
|
|
EXPECT_EQ(e1_in_w2.from(), v1_in_w2);
|
|
EXPECT_EQ(e1_in_w2.to(), v2_in_w2);
|
|
EXPECT_EQ(e1_in_w2.EdgeType(), w2_dba->EdgeType("et"));
|
|
EXPECT_EQ(e1_in_w2.PropsAt(w2_dba->Property("p3")).Value<bool>(), true);
|
|
}
|
|
}
|
|
|
|
TEST_F(DistributedDataExchangeTest, RemoteExpansion) {
|
|
// Model (v1)-->(v2), where each vertex is on one worker.
|
|
auto from = InsertVertex(worker(1));
|
|
auto to = InsertVertex(worker(2));
|
|
InsertEdge(from, to, "et");
|
|
{
|
|
// Expand on the master for three hops. Collect vertex gids.
|
|
auto dba = master().Access();
|
|
std::vector<VertexAccessor> visited;
|
|
|
|
auto expand = [](auto &v) {
|
|
for (auto e : v.out()) return e.to();
|
|
for (auto e : v.in()) return e.from();
|
|
CHECK(false) << "No edge in vertex";
|
|
};
|
|
|
|
// Do a few hops back and forth, all on the master.
|
|
VertexAccessor v{from, *dba};
|
|
for (int i = 0; i < 5; ++i) {
|
|
v = expand(v);
|
|
EXPECT_FALSE(v.address().is_local());
|
|
EXPECT_EQ(v.address(), i % 2 ? from : to);
|
|
}
|
|
}
|
|
}
|
|
|
|
TEST_F(DistributedDataExchangeTest, VertexCountsEqual) {
|
|
for (int i = 0; i < 5; ++i) InsertVertex(master());
|
|
for (int i = 0; i < 7; ++i) InsertVertex(worker(1));
|
|
for (int i = 0; i < 9; ++i) InsertVertex(worker(2));
|
|
|
|
{
|
|
auto accessor = master().Access();
|
|
auto m_cnt =
|
|
master().data_clients().VertexCounts(accessor->transaction().id_);
|
|
auto w1_cnt =
|
|
worker(1).data_clients().VertexCounts(accessor->transaction().id_);
|
|
auto w2_cnt =
|
|
worker(2).data_clients().VertexCounts(accessor->transaction().id_);
|
|
|
|
auto check = [&m_cnt, &w1_cnt, &w2_cnt](int key, int value) {
|
|
return m_cnt[key] == w1_cnt[key] && w1_cnt[key] == w2_cnt[key] &&
|
|
m_cnt[key] == value;
|
|
};
|
|
|
|
EXPECT_TRUE(check(master().WorkerId(), 5));
|
|
EXPECT_TRUE(check(worker(1).WorkerId(), 7));
|
|
EXPECT_TRUE(check(worker(2).WorkerId(), 9));
|
|
}
|
|
}
|
|
|
|
TEST_F(DistributedDataExchangeTest, VertexCountsTransactional) {
|
|
{
|
|
auto accessor = master().Access();
|
|
InsertVertex(master());
|
|
EXPECT_EQ(master().data_clients().VertexCounts(
|
|
accessor->transaction().id_)[master().WorkerId()],
|
|
0);
|
|
}
|
|
// Transaction after insert which should now see the insertion
|
|
{
|
|
auto accessor = master().Access();
|
|
EXPECT_EQ(master().data_clients().VertexCounts(
|
|
accessor->transaction().id_)[master().WorkerId()],
|
|
1);
|
|
}
|
|
}
|