462daf3a2b
- Separating schema definition from schema validation - Updating vertex_accessor and db_accessors with necessary methods - Adding a primary label to Vertex - Adding schema tests - Updating existing tests for storage v3, and deprecating old: - interpreter => interpreter_v2 - query_plan_accumulate_aggregate => storage_v3_query_plan_accumulate_aggregate - query_plan_create_set_remove_delete => storage_v3_query_plan_create_set_remove_delete - query_plan_bag_semantics => storage_v3_query_plan_bag_semantics - query_plan_edge_cases => storage_v3_query_plan_edge_cases - query_plan_v2_create_set_remove_delete => storage_v3_query_plan_v2_create_set_remove_delete - query_plan_match_filter_return => storage_v3_query_plan_match_filter_return
298 lines
12 KiB
C++
298 lines
12 KiB
C++
// Copyright 2022 Memgraph Ltd.
|
|
//
|
|
// Use of this software is governed by the Business Source License
|
|
// included in the file licenses/BSL.txt; by using this file, you agree to be bound by the terms of the Business Source
|
|
// License, and you may not use this file except in compliance with the Business Source License.
|
|
//
|
|
// As of the Change Date specified in that file, in accordance with
|
|
// the Business Source License, use of this software will be governed
|
|
// by the Apache License, Version 2.0, included in the file
|
|
// licenses/APL.txt.
|
|
|
|
#include <algorithm>
|
|
#include <iterator>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "query/context.hpp"
|
|
#include "query/exceptions.hpp"
|
|
#include "query/plan/operator.hpp"
|
|
|
|
#include "query_plan_common.hpp"
|
|
|
|
using namespace memgraph::query;
|
|
using namespace memgraph::query::plan;
|
|
|
|
TEST(QueryPlan, Skip) {
|
|
memgraph::storage::Storage db;
|
|
auto storage_dba = db.Access();
|
|
memgraph::query::DbAccessor dba(&storage_dba);
|
|
|
|
AstStorage storage;
|
|
SymbolTable symbol_table;
|
|
|
|
auto n = MakeScanAll(storage, symbol_table, "n1");
|
|
auto skip = std::make_shared<plan::Skip>(n.op_, LITERAL(2));
|
|
|
|
auto context = MakeContext(storage, symbol_table, &dba);
|
|
EXPECT_EQ(0, PullAll(*skip, &context));
|
|
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(0, PullAll(*skip, &context));
|
|
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(0, PullAll(*skip, &context));
|
|
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(1, PullAll(*skip, &context));
|
|
|
|
for (int i = 0; i < 10; ++i) dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(11, PullAll(*skip, &context));
|
|
}
|
|
|
|
TEST(QueryPlan, Limit) {
|
|
memgraph::storage::Storage db;
|
|
auto storage_dba = db.Access();
|
|
memgraph::query::DbAccessor dba(&storage_dba);
|
|
|
|
AstStorage storage;
|
|
SymbolTable symbol_table;
|
|
|
|
auto n = MakeScanAll(storage, symbol_table, "n1");
|
|
auto skip = std::make_shared<plan::Limit>(n.op_, LITERAL(2));
|
|
|
|
auto context = MakeContext(storage, symbol_table, &dba);
|
|
EXPECT_EQ(0, PullAll(*skip, &context));
|
|
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(1, PullAll(*skip, &context));
|
|
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(2, PullAll(*skip, &context));
|
|
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(2, PullAll(*skip, &context));
|
|
|
|
for (int i = 0; i < 10; ++i) dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(2, PullAll(*skip, &context));
|
|
}
|
|
|
|
TEST(QueryPlan, CreateLimit) {
|
|
// CREATE (n), (m)
|
|
// MATCH (n) CREATE (m) LIMIT 1
|
|
// in the end we need to have 3 vertices in the db
|
|
memgraph::storage::Storage db;
|
|
auto storage_dba = db.Access();
|
|
memgraph::query::DbAccessor dba(&storage_dba);
|
|
dba.InsertVertex();
|
|
dba.InsertVertex();
|
|
dba.AdvanceCommand();
|
|
|
|
AstStorage storage;
|
|
SymbolTable symbol_table;
|
|
|
|
auto n = MakeScanAll(storage, symbol_table, "n1");
|
|
NodeCreationInfo m;
|
|
m.symbol = symbol_table.CreateSymbol("m", true);
|
|
auto c = std::make_shared<CreateNode>(n.op_, m);
|
|
auto skip = std::make_shared<plan::Limit>(c, LITERAL(1));
|
|
|
|
auto context = MakeContext(storage, symbol_table, &dba);
|
|
EXPECT_EQ(1, PullAll(*skip, &context));
|
|
dba.AdvanceCommand();
|
|
EXPECT_EQ(3, CountIterable(dba.Vertices(memgraph::storage::View::OLD)));
|
|
}
|
|
|
|
TEST(QueryPlan, OrderBy) {
|
|
memgraph::storage::Storage db;
|
|
auto storage_dba = db.Access();
|
|
memgraph::query::DbAccessor dba(&storage_dba);
|
|
AstStorage storage;
|
|
SymbolTable symbol_table;
|
|
auto prop = dba.NameToProperty("prop");
|
|
|
|
// contains a series of tests
|
|
// each test defines the ordering a vector of values in the desired order
|
|
auto Null = memgraph::storage::PropertyValue();
|
|
std::vector<std::pair<Ordering, std::vector<memgraph::storage::PropertyValue>>> orderable{
|
|
{Ordering::ASC,
|
|
{memgraph::storage::PropertyValue(0), memgraph::storage::PropertyValue(0), memgraph::storage::PropertyValue(0.5),
|
|
memgraph::storage::PropertyValue(1), memgraph::storage::PropertyValue(2),
|
|
memgraph::storage::PropertyValue(12.6), memgraph::storage::PropertyValue(42), Null, Null}},
|
|
{Ordering::ASC,
|
|
{memgraph::storage::PropertyValue(false), memgraph::storage::PropertyValue(false),
|
|
memgraph::storage::PropertyValue(true), memgraph::storage::PropertyValue(true), Null, Null}},
|
|
{Ordering::ASC,
|
|
{memgraph::storage::PropertyValue("A"), memgraph::storage::PropertyValue("B"),
|
|
memgraph::storage::PropertyValue("a"), memgraph::storage::PropertyValue("a"),
|
|
memgraph::storage::PropertyValue("aa"), memgraph::storage::PropertyValue("ab"),
|
|
memgraph::storage::PropertyValue("aba"), Null, Null}},
|
|
{Ordering::DESC,
|
|
{Null, Null, memgraph::storage::PropertyValue(33), memgraph::storage::PropertyValue(33),
|
|
memgraph::storage::PropertyValue(32.5), memgraph::storage::PropertyValue(32),
|
|
memgraph::storage::PropertyValue(2.2), memgraph::storage::PropertyValue(2.1),
|
|
memgraph::storage::PropertyValue(0)}},
|
|
{Ordering::DESC, {Null, memgraph::storage::PropertyValue(true), memgraph::storage::PropertyValue(false)}},
|
|
{Ordering::DESC, {Null, memgraph::storage::PropertyValue("zorro"), memgraph::storage::PropertyValue("borro")}}};
|
|
|
|
for (const auto &order_value_pair : orderable) {
|
|
std::vector<TypedValue> values;
|
|
values.reserve(order_value_pair.second.size());
|
|
for (const auto &v : order_value_pair.second) values.emplace_back(v);
|
|
// empty database
|
|
for (auto vertex : dba.Vertices(memgraph::storage::View::OLD))
|
|
ASSERT_TRUE(dba.DetachRemoveVertex(&vertex).HasValue());
|
|
dba.AdvanceCommand();
|
|
ASSERT_EQ(0, CountIterable(dba.Vertices(memgraph::storage::View::OLD)));
|
|
|
|
// take some effort to shuffle the values
|
|
// because we are testing that something not ordered gets ordered
|
|
// and need to take care it does not happen by accident
|
|
auto shuffled = values;
|
|
auto order_equal = [&values, &shuffled]() {
|
|
return std::equal(values.begin(), values.end(), shuffled.begin(), TypedValue::BoolEqual{});
|
|
};
|
|
for (int i = 0; i < 50 && order_equal(); ++i) {
|
|
std::random_shuffle(shuffled.begin(), shuffled.end());
|
|
}
|
|
ASSERT_FALSE(order_equal());
|
|
|
|
// create the vertices
|
|
for (const auto &value : shuffled)
|
|
ASSERT_TRUE(dba.InsertVertex().SetProperty(prop, memgraph::storage::PropertyValue(value)).HasValue());
|
|
dba.AdvanceCommand();
|
|
|
|
// order by and collect results
|
|
auto n = MakeScanAll(storage, symbol_table, "n");
|
|
auto n_p = PROPERTY_LOOKUP(IDENT("n")->MapTo(n.sym_), prop);
|
|
auto order_by = std::make_shared<plan::OrderBy>(n.op_, std::vector<SortItem>{{order_value_pair.first, n_p}},
|
|
std::vector<Symbol>{n.sym_});
|
|
auto n_p_ne = NEXPR("n.p", n_p)->MapTo(symbol_table.CreateSymbol("n.p", true));
|
|
auto produce = MakeProduce(order_by, n_p_ne);
|
|
auto context = MakeContext(storage, symbol_table, &dba);
|
|
auto results = CollectProduce(*produce, &context);
|
|
ASSERT_EQ(values.size(), results.size());
|
|
for (int j = 0; j < results.size(); ++j) EXPECT_TRUE(TypedValue::BoolEqual{}(results[j][0], values[j]));
|
|
}
|
|
}
|
|
|
|
TEST(QueryPlan, OrderByMultiple) {
|
|
memgraph::storage::Storage db;
|
|
auto storage_dba = db.Access();
|
|
memgraph::query::DbAccessor dba(&storage_dba);
|
|
AstStorage storage;
|
|
SymbolTable symbol_table;
|
|
|
|
auto p1 = dba.NameToProperty("p1");
|
|
auto p2 = dba.NameToProperty("p2");
|
|
|
|
// create a bunch of vertices that in two properties
|
|
// have all the variations (with repetition) of N values.
|
|
// ensure that those vertices are not created in the
|
|
// "right" sequence, but randomized
|
|
const int N = 20;
|
|
std::vector<std::pair<int, int>> prop_values;
|
|
for (int i = 0; i < N * N; ++i) prop_values.emplace_back(i % N, i / N);
|
|
std::random_shuffle(prop_values.begin(), prop_values.end());
|
|
for (const auto &pair : prop_values) {
|
|
auto v = dba.InsertVertex();
|
|
ASSERT_TRUE(v.SetProperty(p1, memgraph::storage::PropertyValue(pair.first)).HasValue());
|
|
ASSERT_TRUE(v.SetProperty(p2, memgraph::storage::PropertyValue(pair.second)).HasValue());
|
|
}
|
|
dba.AdvanceCommand();
|
|
|
|
// order by and collect results
|
|
auto n = MakeScanAll(storage, symbol_table, "n");
|
|
auto n_p1 = PROPERTY_LOOKUP(IDENT("n")->MapTo(n.sym_), p1);
|
|
auto n_p2 = PROPERTY_LOOKUP(IDENT("n")->MapTo(n.sym_), p2);
|
|
// order the results so we get
|
|
// (p1: 0, p2: N-1)
|
|
// (p1: 0, p2: N-2)
|
|
// ...
|
|
// (p1: N-1, p2:0)
|
|
auto order_by = std::make_shared<plan::OrderBy>(n.op_,
|
|
std::vector<SortItem>{
|
|
{Ordering::ASC, n_p1},
|
|
{Ordering::DESC, n_p2},
|
|
},
|
|
std::vector<Symbol>{n.sym_});
|
|
auto n_p1_ne = NEXPR("n.p1", n_p1)->MapTo(symbol_table.CreateSymbol("n.p1", true));
|
|
auto n_p2_ne = NEXPR("n.p2", n_p2)->MapTo(symbol_table.CreateSymbol("n.p2", true));
|
|
auto produce = MakeProduce(order_by, n_p1_ne, n_p2_ne);
|
|
auto context = MakeContext(storage, symbol_table, &dba);
|
|
auto results = CollectProduce(*produce, &context);
|
|
ASSERT_EQ(N * N, results.size());
|
|
for (int j = 0; j < N * N; ++j) {
|
|
ASSERT_EQ(results[j][0].type(), TypedValue::Type::Int);
|
|
EXPECT_EQ(results[j][0].ValueInt(), j / N);
|
|
ASSERT_EQ(results[j][1].type(), TypedValue::Type::Int);
|
|
EXPECT_EQ(results[j][1].ValueInt(), N - 1 - j % N);
|
|
}
|
|
}
|
|
|
|
TEST(QueryPlan, OrderByExceptions) {
|
|
memgraph::storage::Storage db;
|
|
auto storage_dba = db.Access();
|
|
memgraph::query::DbAccessor dba(&storage_dba);
|
|
AstStorage storage;
|
|
SymbolTable symbol_table;
|
|
auto prop = dba.NameToProperty("prop");
|
|
|
|
// a vector of pairs of typed values that should result
|
|
// in an exception when trying to order on them
|
|
std::vector<std::pair<memgraph::storage::PropertyValue, memgraph::storage::PropertyValue>> exception_pairs{
|
|
{memgraph::storage::PropertyValue(42), memgraph::storage::PropertyValue(true)},
|
|
{memgraph::storage::PropertyValue(42), memgraph::storage::PropertyValue("bla")},
|
|
{memgraph::storage::PropertyValue(42),
|
|
memgraph::storage::PropertyValue(
|
|
std::vector<memgraph::storage::PropertyValue>{memgraph::storage::PropertyValue(42)})},
|
|
{memgraph::storage::PropertyValue(true), memgraph::storage::PropertyValue("bla")},
|
|
{memgraph::storage::PropertyValue(true),
|
|
memgraph::storage::PropertyValue(
|
|
std::vector<memgraph::storage::PropertyValue>{memgraph::storage::PropertyValue(true)})},
|
|
{memgraph::storage::PropertyValue("bla"),
|
|
memgraph::storage::PropertyValue(
|
|
std::vector<memgraph::storage::PropertyValue>{memgraph::storage::PropertyValue("bla")})},
|
|
// illegal comparisons of same-type values
|
|
{memgraph::storage::PropertyValue(
|
|
std::vector<memgraph::storage::PropertyValue>{memgraph::storage::PropertyValue(42)}),
|
|
memgraph::storage::PropertyValue(
|
|
std::vector<memgraph::storage::PropertyValue>{memgraph::storage::PropertyValue(42)})}};
|
|
|
|
for (const auto &pair : exception_pairs) {
|
|
// empty database
|
|
for (auto vertex : dba.Vertices(memgraph::storage::View::OLD))
|
|
ASSERT_TRUE(dba.DetachRemoveVertex(&vertex).HasValue());
|
|
dba.AdvanceCommand();
|
|
ASSERT_EQ(0, CountIterable(dba.Vertices(memgraph::storage::View::OLD)));
|
|
|
|
// make two vertices, and set values
|
|
ASSERT_TRUE(dba.InsertVertex().SetProperty(prop, pair.first).HasValue());
|
|
ASSERT_TRUE(dba.InsertVertex().SetProperty(prop, pair.second).HasValue());
|
|
dba.AdvanceCommand();
|
|
ASSERT_EQ(2, CountIterable(dba.Vertices(memgraph::storage::View::OLD)));
|
|
for (const auto &va : dba.Vertices(memgraph::storage::View::OLD))
|
|
ASSERT_NE(va.GetProperty(memgraph::storage::View::OLD, prop).GetValue().type(),
|
|
memgraph::storage::PropertyValue::Type::Null);
|
|
|
|
// order by and expect an exception
|
|
auto n = MakeScanAll(storage, symbol_table, "n");
|
|
auto n_p = PROPERTY_LOOKUP(IDENT("n")->MapTo(n.sym_), prop);
|
|
auto order_by =
|
|
std::make_shared<plan::OrderBy>(n.op_, std::vector<SortItem>{{Ordering::ASC, n_p}}, std::vector<Symbol>{});
|
|
auto context = MakeContext(storage, symbol_table, &dba);
|
|
EXPECT_THROW(PullAll(*order_by, &context), QueryRuntimeException);
|
|
}
|
|
}
|