gvolfing
b67e5b9a6c
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 07:53:45 +01:00
gvolfing
79756ae6fb
Modify unit test
...
Instead of Creating an exception that is would be only used in this
file, just assert the type of the error the double vertex insertion
operation should yield.
2022-11-08 07:31:01 +01:00
gvolfing
91550128a5
Conform unit test with the new error-handling
2022-11-07 11:46:24 +01:00
gvolfing
39b40ecf00
Extend the Error enum instead of a separate type
...
The error representing that a vertex is already inserted into the
skip-list was represented by the struct AlreadyInseertedElement. Instead
of using that struct, extend the memgraph::storage::v3::Error scoped
enum and use that to represent the double-insertion error.
2022-11-07 10:00:34 +01:00
Tyler Neely
d85fb94bc7
Merge pull request #634 from memgraph/T1122-MG-ShardManager-ThreadPool
...
Add shard manager thread pool
2022-11-04 16:41:53 +01:00
Tyler Neely
1abfe28806
Correctly use a moved transport interface while constructing CoordinatorWorker
2022-11-04 15:11:32 +00:00
Tyler Neely
528e30a9be
Avoid warning for not using captured this. Use std::move instead of forward where appropriate
2022-11-04 14:13:15 +00:00
Tyler Neely
bb7c7f7627
Make popped messages non-const to allow for RVO
2022-11-04 14:07:49 +00:00
gvolfing
3d954e7abc
Restructure SchemaResult type and uts usage
...
Rename SchemaResult to ShardOperationResult move it into a separate
header and add a new type to the underlying variant that indicates that
the vertex, the user would like to insert into the skip-list already
exist.
2022-11-04 15:04:25 +01:00
Tyler Neely
fa5c9a2568
Make items popped from *worker::Queue const. Use std::move instead of std::forward in one place
2022-11-04 11:33:02 +00:00
Tyler Neely
c745f8c877
Fix build after breaking code suggestion
2022-11-04 11:32:17 +00:00
Tyler Neely
486231b1b9
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:28:01 +01:00
Tyler Neely
43ad5855c4
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:27:40 +01:00
Tyler Neely
24864ff7d2
Update src/coordinator/coordinator_worker.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:17:57 +01:00
Tyler Neely
8598f6edf4
Fix a race condition that happens when logging from a detached thread in the cluster property test. Improve the ShardManager dtor and log statements
2022-11-04 11:14:39 +00:00
gvolfing
1cee7ecb8a
Make ShardRsm aware of trying to write the same vertex into the skip-list
2022-11-04 08:12:37 +01:00
Tyler Neely
9203616283
Merge branch 'project-pineapples' into T1122-MG-ShardManager-ThreadPool
2022-11-03 17:01:07 +01:00
Tyler Neely
d198819bf1
Merge pull request #637 from memgraph/tyler_remove_storage_v2_durability_test
...
Remove unit tests for storage v2
2022-11-03 17:00:46 +01:00
Tyler Neely
7e6ec8bb26
Capture this instead of all references in scope for call to std::visit to route CoordinatorWorker messages
2022-11-03 14:38:16 +00:00
Tyler Neely
6138d76690
Remove unit tests for storage v2
2022-11-03 14:21:17 +00:00
Tyler Neely
25fdb1a1f0
Make the high_density_shard_create_scan test run much faster
2022-11-03 13:48:11 +00:00
Tyler Neely
2de1d6c359
Fix UB due to integer overflow
2022-11-03 13:27:45 +00:00
Tyler Neely
0364311dd0
Log latency histograms in the high_density_shard_create_scan test
2022-11-03 12:44:47 +00:00
Tyler Neely
9235515dab
Reduce high_density_shard_create_scan shard+thread combinations. Log Raft write request demangled names
2022-11-03 12:38:12 +00:00
Tyler Neely
b83fb287ad
Apply feedback from clang-tidy
2022-11-03 11:00:07 +00:00
Tyler Neely
b685a21171
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-11-03 09:42:28 +00:00
Tyler Neely
4db83b8159
Add a few safety checks to the new concurrent Queue structures and the promise maps in the transport layer
2022-11-03 09:41:28 +00:00
Tyler Neely
dd8dd4f6c4
Restructure responsibilities for assigning request ids to the transport handles. Simplify promise tracking to avoid replier addresses, enabling eventual direct server return (DSR)
2022-11-03 09:31:06 +00:00
Tyler Neely
fa1ddfea12
Fix a bug where the MachineManager's destructor became incorrect after being moved
2022-11-02 17:45:27 +00:00
Tyler Neely
a815ec9617
Handle Coordinator work on a separate thread, unblocking the MachineManager to route additional messages to Shards
2022-11-02 17:15:52 +00:00
Tyler Neely
78528bd609
Avoid the ShutDown explicit acknowledgement due to jthread already blocking on this
2022-11-02 17:12:21 +00:00
Tyler Neely
6239f4fc3e
Simplify usage of PromiseKey in LocalTransportHandle to avoid replier address
2022-11-02 17:11:26 +00:00
János Benjamin Antal
9f71ce0f78
Merge pull request #635 from memgraph/MG-expand-fixes
2022-11-02 15:55:49 +01:00
János Benjamin Antal
589dd36bf2
Make function parameter constant
2022-11-02 14:44:54 +01:00
János Benjamin Antal
57e7169203
Eliminate dangling reference from lambda
2022-11-02 14:22:01 +01:00
János Benjamin Antal
bb3b053375
Create edge in the correct direction
2022-11-02 14:22:01 +01:00
János Benjamin Antal
a96f489756
Count the number of requests per operator
2022-11-02 14:22:01 +01:00
János Benjamin Antal
c92c795b1a
Merge pull request #632 from memgraph/MG-improve-parameters
2022-11-02 14:06:30 +01:00
János Benjamin Antal
0fee412f92
Merge branch 'project-pineapples' into MG-improve-parameters
2022-11-02 13:37:35 +01:00
Tyler Neely
7596e85358
When message conversion fails to happen, demangle the concrete type name and error log a useful message
2022-11-02 12:37:34 +00:00
Tyler Neely
68654b5a19
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-11-02 10:55:18 +00:00
János Benjamin Antal
4d96bf5006
Merge pull request #628 from memgraph/T1138-MG-fix-edge-id-allocator
...
Fix passing of edge IdAllocator not by value but as pointer
2022-11-02 10:40:35 +01:00
Marko Budiselić
9bb70eb0b9
Merge branch 'project-pineapples' into T1138-MG-fix-edge-id-allocator
2022-11-01 19:38:10 +01:00
Tyler Neely
ee4be9aa5b
Merge pull request #631 from memgraph/tyler_remove_shard_map_from_machine_manager
...
Remove redundant ShardMap copy from MachineManager to avoid race conditions
2022-11-01 18:33:37 +01:00
Tyler Neely
84509fa477
Fix merge conflict with MachineManager constructor
2022-11-01 17:07:14 +00:00
Tyler Neely
19b5fe3caf
Merge branch 'project-pineapples' into tyler_remove_shard_map_from_machine_manager
2022-11-01 17:57:03 +01:00
Tyler Neely
74db669e23
Merge pull request #622 from memgraph/tyler_1k_shard_unit_test
...
Add test for 1k shards, 1k create vertices, and then a scan all
2022-11-01 17:56:42 +01:00
Tyler Neely
599802033f
Reformat TODO comment
2022-11-01 17:21:15 +01:00
Tyler Neely
6dd57426f8
Revert broken code suggestion
2022-11-01 15:51:37 +00:00
Tyler Neely
3c9f0c48e9
Merge branch 'project-pineapples' into tyler_1k_shard_unit_test
2022-11-01 16:31:29 +01:00
