tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,163 Commits 247 Branches 35 Tags 62 MiB
9d1265f41f
Commit Graph

1163 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dominik Gleich
461ea65ad4 Deferred deleter added. 
Summary:
Add tests.

Merge branch 'dev' into remove_locks

Everything works. Refactor complete.

Documentation:
https://phabricator.memgraph.io/w/memgraph_implementation/indexing/

Reviewers: buda, mislav.bradac, florijan

Reviewed By: florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D258
 2017-04-14 17:46:16 +02:00
florijan
0a09a6ac64 Storage, Query - deletion bugfix and improvements 
Summary:
Multiple attempts to delete a record dont crash anymore.
Deleting a vertex and its blocking edge in the same delete op now supported.
Utils::Assert - permanent_fail bug fix

Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D282
 2017-04-14 16:34:38 +02:00
florijan
3d0181b28b Query::Plan::Aggregation - optional input bugfix 
Reviewers: teon.banek, mislav.bradac

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D280
 2017-04-14 15:06:24 +02:00
Mislav Bradac
bba20cf89c Remove unneccessary files from utils 
Reviewers: buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D276
 2017-04-13 17:55:33 +02:00
florijan
59a9aaea16 Query::Context - removed some junk 
Reviewers: teon.banek, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D278
 2017-04-13 16:49:18 +02:00
Teon Banek
67b7428e5e Reset in_create_node flag during symbol generation 
Reviewers: florijan, mislav.bradac

Reviewed By: florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D279
 2017-04-13 16:44:51 +02:00
Matej Gradiček
9ab4beac60 Removed wrong test 
Reviewers: teon.banek

Reviewed By: teon.banek

Differential Revision: https://phabricator.memgraph.io/D277
 2017-04-13 14:43:14 +00:00
Marko Budiselic
38c40096c5 Interpreter build script + dockerfile. 
Summary: Interpreter build script + dockerfile.

Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot, buda

Differential Revision: https://phabricator.memgraph.io/D275
 2017-04-13 14:58:14 +02:00
Teon Banek
15d5328957 Check if aggregation is used in right clause 
Reviewers: florijan, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D274
 2017-04-13 13:31:52 +02:00
Matej Gradiček
0c5b2bdc8e Added unstable option to tck_executor and any error checker in steps/errors.py. 
Reviewers: buda, mislav.bradac

Reviewed By: buda, mislav.bradac

Differential Revision: https://phabricator.memgraph.io/D268
 2017-04-13 10:24:16 +00:00
florijan
d9e02d624d Query::TypedValue - equality, functionality 
Summary:
Changed the equality to always return Null or Bool TypedValue and never throw.
Changed BoolEquality to use the new raw equality.
Added equality, BoolEquality and hash support for Type::Map.
Added tests for new stuff.

Reviewers: teon.banek, mislav.bradac

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D273
 2017-04-13 11:50:47 +02:00
Teon Banek
3b27b20992 Reorganize query directory tree 
Summary:
Move query/frontend/interpret to query/interpret.
Split interpret.hpp to frame.hpp and eval.hpp.
Move query/frontend/logical to query/plan.
Nest namespace frontend::opencypher inside query.

Reviewers: florijan, mislav.bradac, buda

Reviewed By: florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D272
 2017-04-13 11:28:11 +02:00
florijan
c89c65a748 Query::Plan::Aggregate - count edge-case fix 
Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D270
 2017-04-13 08:30:34 +02:00
Dominik Gleich
afbec0a26e Test GarbageCollector in skiplist. 
Summary: Tests the skiplist GC.

Reviewers: florijan, mferencevic, buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D145
 2017-04-12 17:02:29 +02:00
Teon Banek
596b015e99 Correctly check variables inside property maps 
Reviewers: florijan, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D271
 2017-04-12 16:44:16 +02:00
Mislav Bradac
55ef48c78e Add antlr error description to SyntaxException 
Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D269
 2017-04-12 15:51:21 +02:00
Teon Banek
b69c162c9f Add base QueryException class 
Summary:
Also, inherit `TypedValueException` from `BasicException` instead of
`StacktraceException`.

This is meant as a basic API change, so that catching query exceptions becomes
simpler. The error message can be obtained from `what` method, inherited from
`BasicException`. In the future, we may extend the `QueryException`. It could
take column/row position in query source, as well as other information. Then
provide (or override `what`) a method to format the error message nicely for
the user.

Reviewers: florijan, buda, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D267
 2017-04-12 15:35:51 +02:00
florijan
ea202dc52a Query::Plan::EdgeFilter bugfix 
Summary:
Resolved the bug where edge filters with no edge-types dont accept any edge.
Illustrated with the following queries:
CREATE ()-[]->()
MATCH ()-[]->()
	(produces 0 results, expected 1)

Reviewers: mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D265
 2017-04-12 13:47:27 +02:00
Teon Banek
355b9a9b9a Plan aggregation in WITH and RETURN clauses 
Summary:
Generate symbols for aggregation results.
Plan aggregation in WITH clause.
Plan aggregation in RETURN clause.
Extract handling write clauses to a function.

Reviewers: mislav.bradac, florijan

Reviewed By: mislav.bradac, florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D236
 2017-04-12 13:22:23 +02:00
Teon Banek
6cb1cdc607 Raise if setting label/property in CREATE on declared node 
Reviewers: florijan, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D266
 2017-04-12 11:11:27 +02:00
Teon Banek
0000e83fc7 Add sync option to init script 
Reviewers: mferencevic, buda

Reviewed By: buda

Differential Revision: https://phabricator.memgraph.io/D263
 2017-04-12 10:21:55 +02:00
Teon Banek
6ed297e1d9 Remove src/query/util.hpp 
Summary:
`query/util.hpp` isn't used anywhere, but in `copy_hardcoded_queries.cpp`. That
file may be removed in the future, but for now it is needed.

Reviewers: mislav.bradac, florijan, buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D261
 2017-04-12 10:20:59 +02:00
Mislav Bradac
36129cdcae Implement simple function conversion 
Reviewers: buda

Reviewed By: buda

Subscribers: florijan, teon.banek

Differential Revision: https://phabricator.memgraph.io/D264
 2017-04-11 19:14:08 +02:00
florijan
1273cea870 EdgeAccessor::is_cycle added. Query::Plan::Expand fixed 
Reviewers: mislav.bradac

Reviewed By: mislav.bradac

Differential Revision: https://phabricator.memgraph.io/D262
 2017-04-11 15:52:01 +02:00
florijan
593e4e72b9 Query::Plan::Aggregate 
Summary:
- Aggregation LogicalOperation added, with tests.

- Added capabilities to TypedValue (hash, bool-equality)
to support std::unordered_map<TypedValue>.

- Removed some bad code from utils/hashing/fnv and added
a hashing function for collections.

Reviewers: buda, mislav.bradac, teon.banek

Reviewed By: teon.banek

Subscribers: lion, pullbot

Differential Revision: https://phabricator.memgraph.io/D252
 2017-04-11 15:12:06 +02:00
Mislav Bradac
dfa6800edd Add aggregation conversion from antlr to ast 
Reviewers: teon.banek

Reviewed By: teon.banek

Differential Revision: https://phabricator.memgraph.io/D260
 2017-04-11 14:55:26 +02:00
florijan
7981bd19e0 Query::Plan - const correctness 
Summary:
Made all LogicalOperators const correct.
Fixed one LogicalOperator test.
Added explicit return values to Frame and SymbolTable at and [] methods.

Reviewers: teon.banek

Reviewed By: teon.banek

Differential Revision: https://phabricator.memgraph.io/D259
 2017-04-11 14:27:56 +02:00
Mislav Bradac
d92caf1163 Check clauses ordering 
Reviewers: buda, florijan, teon.banek

Reviewed By: buda, teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D257
 2017-04-11 12:30:17 +02:00
Teon Banek
804d0b09b9 Move typed_value to query top level and namespace it 
Summary:
Upgraded old uses of TypedValue.
Also, implemented operator<< for EdgeAccessor and VertexAccessor.

Reviewers: buda, florijan, mislav.bradac, mferencevic

Reviewed By: florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D251
 2017-04-11 08:50:46 +02:00
Mislav Bradac
cba99a4344 Uncomment tests that pass after bug fixes 
Reviewers: buda

Reviewed By: buda

Differential Revision: https://phabricator.memgraph.io/D255
 2017-04-10 17:21:34 +02:00
Mislav Bradac
b7ee09785b Implement IS NULL and IS NOT NULL 
Reviewers: teon.banek, florijan

Reviewed By: florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D254
 2017-04-10 16:55:58 +02:00
Dominik Gleich
fd2780155a Refactor GC to use scheduler. 
Reviewers: buda, matej.gradicek

Reviewed By: matej.gradicek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D247
 2017-04-10 15:57:45 +02:00
Teon Banek
9855621c9e Fix planning CREATE with expanding a created node 
Reviewers: florijan, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D253
 2017-04-10 15:11:23 +02:00
Teon Banek
7d0958b1a4 Add PreVisit method to utils::Visitor 
Reviewers: florijan, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D242
 2017-04-10 15:03:02 +02:00
Dominik Gleich
e8fd479bbc Fix memory leak. Refactor mvcc. Revert commit function to old and introduce new one. 
Summary:
Update tests.

Documentation:
https://phabricator.memgraph.io/w/memgraph_implementation/mvcc/

Reviewers: mislav.bradac, florijan, buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D227
 2017-04-10 12:16:03 +02:00
Teon Banek
64d0163aad Handle QueryRuntimeException in AM-REPL 
Reviewers: florijan

Reviewed By: florijan

Differential Revision: https://phabricator.memgraph.io/D250
 2017-04-10 09:13:14 +02:00
Dominik Gleich
aca6b8f38b Fix dead code - and accompanying warnings. 
Reviewers: mferencevic, matej.gradicek, mislav.bradac

Reviewed By: mferencevic

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D248
 2017-04-10 09:11:30 +02:00
Mislav Bradac
7a58ec5afb Fix bug in parenthesized expression 
Reviewers: buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D249
 2017-04-07 18:33:07 +02:00
Matej Ferencevic
db740fb9fc Started working on network hang fix. 
Reviewers: buda

Reviewed By: buda

Subscribers: pullbot, mislav.bradac

Differential Revision: https://phabricator.memgraph.io/D228
 2017-04-07 17:09:58 +02:00
Dominik Gleich
2032466e2a New version of scheduler. 
Summary: New scheduler declaration.

Reviewers: matej.gradicek, buda

Reviewed By: matej.gradicek

Differential Revision: https://phabricator.memgraph.io/D246
 2017-04-07 11:55:10 +02:00
Dominik Gleich
74740dd162 Fix gradiceks mess. 
Summary: Fix fix fix.

Reviewers: matej.gradicek

Reviewed By: matej.gradicek

Differential Revision: https://phabricator.memgraph.io/D245
 2017-04-07 10:55:40 +02:00
Mislav Bradac
45ea36d58c Comment failing scenarios, exit with 1 if failing 
Reviewers: buda

Reviewed By: buda

Differential Revision: https://phabricator.memgraph.io/D244
 2017-04-07 10:41:11 +02:00
Matej Ferencevic
22dfe61fe1 Added socket write verification to bolt buffer. 
Reviewers: buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D199
 2017-04-07 10:06:55 +02:00
Matej Ferencevic
72f7b64c8f Logger in this test somehow breaks code coverage. Argh... 
Reviewers: buda, dgleich

Reviewed By: dgleich

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D240
 2017-04-07 09:44:12 +02:00
Teon Banek
984c898cfe init: Add optional & required dependency checking 
Reviewers: mferencevic, buda

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D238
 2017-04-07 09:27:12 +02:00
Mislav Bradac
a1be0d5ad7 Begin qa refactor 
Reviewers: mferencevic, matej.gradicek, buda

Reviewed By: buda

Differential Revision: https://phabricator.memgraph.io/D225
 2017-04-06 16:17:36 +02:00
Dominik Gleich
ebff4687a1 Default should be the compiler for the test. 
Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D241
 2017-04-06 16:12:55 +02:00
Dominik Gleich
e8fe25bc61 Remove move constructor and delete move = 
Reviewers: florijan, mislav.bradac

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D237
 2017-04-06 14:38:48 +02:00
Matej Ferencevic
e5c814e022 First version of new bolt decoder and tests. 
Summary:
Extracted constants to codes.hpp.

Extracted bolt constants.

Extracted StreamBuffer and fixed data type.

Extracted bolt testdata.

Added bolt buffer and tests.

Added bolt decoder buffer and tests.

Renamed bolt testdata.

Reviewers: dgleich, buda, matej.gradicek

Reviewed By: buda

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D220
 2017-04-06 14:30:19 +02:00
Teon Banek
aa6cae0b16 Plan WITH clause without aggregation 
Summary: Generate symbols for WITH clause.

Reviewers: florijan, mislav.bradac, buda

Reviewed By: mislav.bradac

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D231
 2017-04-06 14:10:28 +02:00