Tyler Neely
6d3c04bd61
Address clang-tidy feedback
2022-11-28 10:09:59 +00:00
Tyler Neely
a8dc6fd41e
Change the namespace of ShardRequestManager to query::v2 instead of msgs
2022-11-28 09:43:56 +00:00
Tyler Neely
de84d4d6ea
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1157-MG-concurrent-RsmClient-requests
2022-11-28 08:53:21 +00:00
Kostas Kyrimis
6f4996de0e
Fix broken merge and address GH comments
2022-11-25 16:20:38 +02:00
Kostas Kyrimis
01d5953bb6
Merge branch 'project-pineapples' into T1159-MG-Add-memgraph-functions
2022-11-25 15:47:44 +02:00
Kostas Kyrimis
7a3caa320c
WiP
2022-11-24 15:29:51 +02:00
Kostas Kyrimis
07a8ac0db8
Merge branch 'project-pineapples' into T0919-MG-implement-get-properties-storage
2022-11-24 15:29:05 +02:00
János Benjamin Antal
3b798ab313
Merge branch 'project-pineapples' into MG-implicit-fallthrough-as-error
2022-11-24 11:16:57 +01:00
János Benjamin Antal
c4327cfb00
Make implicit-fallthrough a compilation error
2022-11-24 11:13:55 +01:00
jbajic
d820d0a9e5
Fix clang tidy errors
2022-11-23 22:29:03 +01:00
jbajic
7aa68164f0
Merge branch 'project-pineapples' into T0995-MG-implement-top-error-handling-storage
2022-11-23 21:55:08 +01:00
jbajic
d6b444c38b
Log transaction id
2022-11-23 18:02:00 +01:00
jbajic
b3eec92525
Merge branch 'project-pineapples' into T0995-MG-implement-top-error-handling-storage
2022-11-23 16:11:58 +01:00
jbajic
ab5fc05fd7
Address review comments
2022-11-23 15:32:28 +01:00
jeremy
e77843f2ec
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 14:47:29 +01:00
Kostas Kyrimis
2ff81ebf04
Address missed GH comments && fix broken merge
2022-11-23 15:16:14 +02:00
jeremy
c3c68cc2ce
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 13:55:02 +01:00
jeremy
6d86801be0
Extract logic to convert ORderingDirection to Ordering
2022-11-23 13:54:54 +01:00
Kostas Kyrimis
407418e8f5
Merge branch 'project-pineapples' into T1159-MG-Add-memgraph-functions
2022-11-23 14:53:53 +02:00
Kostas Kyrimis
6d544e4fc0
Address GH comments
2022-11-23 14:51:38 +02:00
Jeremy B
56e2ad4546
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2022-11-23 13:24:35 +01:00
Tyler Neely
5045323b1d
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1157-MG-concurrent-RsmClient-requests
2022-11-23 11:31:14 +00:00
Jeremy B
aa146d28f8
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 12:26:58 +01:00
János Benjamin Antal
1cd10ab409
Merge branch 'project-pineapples' into T1116-MG-update-delete-vertex-labels
2022-11-23 12:15:34 +01:00
Jure Bajic
e565fc6e3a
Merge branch 'project-pineapples' into T0995-MG-implement-top-error-handling-storage
2022-11-23 02:33:07 -08:00
jbajic
ce0f1a09f7
Remove unused methods from accessors
2022-11-23 11:32:53 +01:00
jbajic
accf015dcf
Fix clang-tidy errors
2022-11-23 11:03:17 +01:00
Jeremy B
84800cff76
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 10:57:05 +01:00
jbajic
9fade5ebac
Fix tests
2022-11-23 10:37:33 +01:00
Jure Bajic
75606dfeb0
Merge branch 'project-pineapples' into T1116-MG-update-delete-vertex-labels
2022-11-23 00:34:27 -08:00
János Benjamin Antal
9c36d8928a
Merge branch 'project-pineapples' into MG-remove-unused-storage-files
2022-11-23 09:19:14 +01:00
Kostas Kyrimis
9ec72bd969
Add GetProperties shard handler and tests
2022-11-22 19:44:22 +02:00
jeremy
85034ddcbe
Rename variable un function def
2022-11-22 17:29:02 +01:00
Tyler Neely
ea533f43fc
Print out the simulator seed when we exceed the configured abort_time
2022-11-22 16:06:57 +00:00
Tyler Neely
e0086e5666
Use spdlog::trace instead of info for simulator-related messages
2022-11-22 16:06:35 +00:00
Tyler Neely
c0a103e851
Do not advance the clock with every message, as this prevents messages of a certain request depth from ever completing
2022-11-22 16:00:06 +00:00
jeremy
3a171376d7
OrderBy in Expand has two members to differ vertices Vs edges
2022-11-22 16:47:25 +01:00
jbajic
cd7b33f23f
use comparison between ErrorCode and ShardError
2022-11-22 16:22:42 +01:00
jbajic
d82cfb349e
Use ShardResult
2022-11-22 15:00:32 +01:00
jeremy
6801d6ff09
Remove duplicate using statement
2022-11-22 14:49:54 +01:00
jbajic
f1e360469a
Expand SHARD_ERROR with fmt format
2022-11-22 14:44:28 +01:00
jeremy
307cce9e21
Remove unused struct
2022-11-22 14:23:24 +01:00
jeremy
662fa2e6d2
Remove uneeded using statement
2022-11-22 14:22:19 +01:00
jeremy
c0cb53e156
Replace if by switch
2022-11-22 14:20:22 +01:00
jeremy
742017548f
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-22 14:11:48 +01:00
Jeremy B
bbbd722eeb
Update src/storage/v3/request_helper.hpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com>
2022-11-22 14:11:29 +01:00
jeremy
f463d9f59f
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-22 14:10:07 +01:00
Jeremy B
a6f3937692
Update src/storage/v3/request_helper.hpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com>
2022-11-22 14:10:02 +01:00
jbajic
5717dfb165
Add ErrorCode to SHARD_ERROR macro
2022-11-22 14:05:04 +01:00
jeremy
1101c2444c
Make ConvertPropertyMap expect ref and not rvalue
2022-11-22 14:01:16 +01:00
jbajic
2a6dc7bb93
Remove success
2022-11-22 13:49:12 +01:00
jbajic
d080e260e6
Remove redundant code
2022-11-22 13:27:02 +01:00
jbajic
37f5fb29ea
Introduce BoltResult
2022-11-22 13:15:32 +01:00
Tyler Neely
c8c72de6ac
Use duration_cast to ensure that we are retrieving milliseconds inside SimulatorStats::operator<<
2022-11-22 11:30:24 +00:00
jbajic
bffef1a653
Use experimental source location
2022-11-22 11:13:23 +01:00
Tyler Neely
66f39f2681
Add elapsed time to the SimulatorStats
2022-11-22 08:55:48 +00:00
Tyler Neely
081c3e5bed
Capitalize unsigned integer literal
2022-11-21 13:16:35 +00:00
jeremy
ce8bc522d0
Clang warning
2022-11-21 12:23:04 +01:00
Tyler Neely
0f66ae31dd
Use explicit unsigned integer in right shift operation
2022-11-21 11:11:39 +00:00
jeremy
e9e42a0614
add * token to variable declaration
2022-11-21 11:50:56 +01:00
jeremy
4eb673c7b9
Add const to variable
2022-11-21 11:31:22 +01:00
Tyler Neely
71dcba331e
Increment simulator time by up to 30ms in ticks
2022-11-21 10:10:45 +00:00
Tyler Neely
e43f4e2181
Sort simulator in_flight_ messages based on a stable sort of the sender address
2022-11-21 10:08:42 +00:00
jeremy
b2050d55ce
Add const
2022-11-21 10:59:38 +01:00
jeremy
2fc1aeb087
Remove unneeded using statements
2022-11-21 10:59:16 +01:00
jeremy
86e5b44c1c
Remove Shard::Accessor (unsued)
2022-11-21 10:42:15 +01:00
jeremy
1b0db5289d
OrderByVertices only keeps OrderBy expression which corresponds to Vertices
2022-11-21 10:41:08 +01:00
Tyler Neely
45badbe21f
Use unsigned integer literals for bit shifting in the NewShardUuid function
2022-11-18 17:22:50 +00:00
Tyler Neely
ce45a548c7
Significantly improve the determinism of the coordinator, UUID generation, the machine manager, the shard manager, and the cluster property test
2022-11-18 16:42:18 +00:00
Tyler Neely
7115a7e75b
Apply clang-tidy fixes
2022-11-18 10:24:19 +00:00
Tyler Neely
0f32407bdc
Add compare header to histogram collector header
2022-11-18 10:20:45 +00:00
Tyler Neely
a37e7e4aff
Add assert to ensure TestAddress will not be higher than the uchar max
2022-11-18 10:19:55 +00:00
Tyler Neely
6b9a617df0
Streamline simulator tick condition varible notification. Advance time more aggressively
2022-11-18 09:20:15 +00:00
Tyler Neely
923325b8fa
Progress the simulator clock even when there are messages to deliver
2022-11-18 09:04:29 +00:00
Tyler Neely
f6017697d6
Make raft tests fully deterministic for rng_seeds between 0 and 500 at 1% message loss
2022-11-17 21:32:55 +00:00
Tyler Neely
cf73ed529d
Block messages from being delivered upon ShutDown
2022-11-17 21:27:48 +00:00
Tyler Neely
262df5c6a2
Avoid unordered_map in Raft code for more determinism
2022-11-17 21:24:13 +00:00
Tyler Neely
098084314e
Make TestAddress deterministically sortable
2022-11-17 21:22:41 +00:00
Tyler Neely
12880fc71a
Don't advance the simulator handle from server threads themselves
2022-11-17 18:27:12 +00:00
Tyler Neely
80d6776210
Improve simulator determinism
2022-11-17 17:36:46 +00:00
jeremy
3840c14846
Remove nocommit comment
2022-11-17 14:33:08 +01:00
jeremy
fe03f5b206
Update include to full path
...
add auto To variable declaration
2022-11-17 14:11:25 +01:00
jeremy
5f88e75571
Remove double declaration
2022-11-17 14:10:49 +01:00
jeremy
27495ef43a
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-17 13:34:08 +01:00
jeremy
a499bf6dfd
Rename variable
2022-11-17 13:33:11 +01:00
Jeremy B
49652d0a61
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2022-11-17 13:32:48 +01:00
jeremy
6e44c2295d
Remove template from OrderByEdges + move to impl file
2022-11-17 13:30:39 +01:00
jeremy
d482f7da90
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-17 12:59:37 +01:00
Jeremy B
77ab07d991
Update src/storage/v3/request_helper.hpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2022-11-17 12:58:39 +01:00
jeremy
38b0b308ce
Remove unnecessary reserve
2022-11-17 12:58:28 +01:00
jeremy
2f55491271
use std::SameAsAnyOf i.o. is_sale_v
2022-11-17 12:45:15 +01:00
Jeremy B
68e51e73ba
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2022-11-17 12:42:36 +01:00
jeremy
a17a6aea5a
rename variable vertice->vertex
2022-11-17 12:27:12 +01:00
jbajic
ec4804b72a
Move ErrorCode to common
2022-11-17 11:03:03 +01:00
jbajic
e98ef634de
Ignore warning
2022-11-16 21:03:36 +01:00
jeremy
c4e22ffde3
Remove unnecessary tag
2022-11-16 18:51:57 +01:00
jeremy
b3ef0ccd71
Moving function from shard_rsm to helper files
2022-11-16 18:50:22 +01:00
jbajic
15fc3c0834
Fix error
2022-11-16 18:12:25 +01:00
jbajic
9261fabe60
Adapt for unfound object
2022-11-16 17:41:43 +01:00
jbajic
7bdcd8f9f4
Add shard_error in response
2022-11-16 14:48:06 +01:00
jeremy
bd11225d23
Use ref instead of optional
...
Use ref i.o. ptr
Rename variable for clarity
2022-11-16 14:14:35 +01:00
jbajic
14ddd7254d
Fix communication and memgraph
2022-11-15 19:37:24 +01:00
jbajic
8629ee5ebc
Fix query v2
2022-11-15 19:30:34 +01:00
jbajic
1c94c59a24
Fix tests
2022-11-15 19:29:56 +01:00
Tyler Neely
631d18465b
Allow the RsmClient to store multiple in-flight requests. Update the ShardRequestManager to use the new request tokens and refactor some bug-prone aspects of it
2022-11-15 17:52:38 +00:00
jbajic
3f97a13493
Revert TError to Error
2022-11-15 18:30:25 +01:00
jbajic
5656a24c96
Remove unused exception
2022-11-15 18:25:25 +01:00
jbajic
9c05910e68
Adapt storage to new erro handling
2022-11-15 18:25:12 +01:00
jbajic
3d66bbd988
Remove shard_operation_result
2022-11-15 18:24:40 +01:00
jbajic
07032887a4
Adapt mg-expr
2022-11-15 18:24:28 +01:00
Kostas Kyrimis
9e81fe791c
Fix clang-tidy warnings, remove commented out code and add HasLabel
...
functions in ShardRequestManager to avoid throwing bad optional on
expression evaluator
2022-11-15 19:20:01 +02:00
jeremy
cca4e97bcf
Remove un-needed argument from OrderByEdges
2022-11-15 13:37:43 +01:00
Kostas Kyrimis
02ef954e51
Add mg-functions lib and integrated with SE and QE
2022-11-14 20:46:16 +02:00
jeremy
131d7f2a74
OrderByElements: no longer templated over vertice/edge types. For edges, we always need to have access to the corresponding vertex_accessor (ex of sorting expr needing both : "vertex.map[edge]")
...
ComputeExpression: made assert instead of if check
2022-11-14 18:21:03 +01:00
jbajic
618237cc96
Adapt schema validator
2022-11-14 14:25:20 +01:00
jbajic
ef755e466c
Add ShardError
2022-11-14 14:15:29 +01:00
Jure Bajic
a9c5d40721
Update src/utils/template_utils.hpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2022-11-14 10:32:18 +01:00
jbajic
b4c24f4506
Remvoe storage.hpp and storage.cpp files
2022-11-14 10:23:48 +01:00
jbajic
0462b8fc8f
Address review comments
2022-11-14 09:15:03 +01:00
jbajic
6eabceca4a
Add unit tests for UpdateVertex
2022-11-14 09:02:55 +01:00
jeremy
2045f54577
Correct merge issue
2022-11-09 21:36:41 +01:00
Jeremy B
18009c06b6
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-09 16:47:06 +01:00
jbajic
a030419565
Move LogResultError to helper
2022-11-09 16:07:27 +01:00
jbajic
8636788ab2
Fix typos
2022-11-09 16:00:25 +01:00
jbajic
691f6af36d
Remove redundant code
2022-11-09 15:52:08 +01:00
jbajic
23f1536eac
Add tests
2022-11-09 15:42:09 +01:00
jbajic
a2735c8953
Add label add/remove in UpdateVertex req
2022-11-09 12:10:46 +01:00
János Benjamin Antal
32fe4d94d9
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 16:35:38 +01:00
jeremy
b2f3fab693
Remove comment
2022-11-08 15:06:27 +01:00
jeremy
d7ce7cea13
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-08 15:02:56 +01:00
János Benjamin Antal
159b30ba5f
Merge branch 'project-pineapples' into T1148-MG-fix-expand-one-source-vertex
2022-11-08 08:20:25 +01:00
gvolfing
b67e5b9a6c
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 07:53:45 +01:00
jbajic
88487e2513
Extract vertex creation from FillUpSourceVertexSecondaryLabels
2022-11-07 10:54:28 +01:00
gvolfing
39b40ecf00
Extend the Error enum instead of a separate type
...
The error representing that a vertex is already inserted into the
skip-list was represented by the struct AlreadyInseertedElement. Instead
of using that struct, extend the memgraph::storage::v3::Error scoped
enum and use that to represent the double-insertion error.
2022-11-07 10:00:34 +01:00
Tyler Neely
1abfe28806
Correctly use a moved transport interface while constructing CoordinatorWorker
2022-11-04 15:11:32 +00:00
Tyler Neely
528e30a9be
Avoid warning for not using captured this. Use std::move instead of forward where appropriate
2022-11-04 14:13:15 +00:00
Tyler Neely
bb7c7f7627
Make popped messages non-const to allow for RVO
2022-11-04 14:07:49 +00:00
jbajic
bab5e1386a
Address review comments
2022-11-04 15:05:55 +01:00
gvolfing
3d954e7abc
Restructure SchemaResult type and uts usage
...
Rename SchemaResult to ShardOperationResult move it into a separate
header and add a new type to the underlying variant that indicates that
the vertex, the user would like to insert into the skip-list already
exist.
2022-11-04 15:04:25 +01:00
Tyler Neely
fa5c9a2568
Make items popped from *worker::Queue const. Use std::move instead of std::forward in one place
2022-11-04 11:33:02 +00:00
Tyler Neely
c745f8c877
Fix build after breaking code suggestion
2022-11-04 11:32:17 +00:00
Tyler Neely
486231b1b9
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:28:01 +01:00
Tyler Neely
43ad5855c4
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:27:40 +01:00
Tyler Neely
24864ff7d2
Update src/coordinator/coordinator_worker.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:17:57 +01:00
Tyler Neely
8598f6edf4
Fix a race condition that happens when logging from a detached thread in the cluster property test. Improve the ShardManager dtor and log statements
2022-11-04 11:14:39 +00:00
gvolfing
1cee7ecb8a
Make ShardRsm aware of trying to write the same vertex into the skip-list
2022-11-04 08:12:37 +01:00
jbajic
3a8f01af79
Fix expand one source vertex pk setting
2022-11-03 16:29:28 +01:00
Tyler Neely
7e6ec8bb26
Capture this instead of all references in scope for call to std::visit to route CoordinatorWorker messages
2022-11-03 14:38:16 +00:00
Tyler Neely
2de1d6c359
Fix UB due to integer overflow
2022-11-03 13:27:45 +00:00
Tyler Neely
9235515dab
Reduce high_density_shard_create_scan shard+thread combinations. Log Raft write request demangled names
2022-11-03 12:38:12 +00:00
