jbajic
691f6af36d
Remove redundant code
2022-11-09 15:52:08 +01:00
jbajic
23f1536eac
Add tests
2022-11-09 15:42:09 +01:00
jbajic
a2735c8953
Add label add/remove in UpdateVertex req
2022-11-09 12:10:46 +01:00
János Benjamin Antal
3c07a5dc04
Merge pull request #639 from memgraph/T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
...
Return an error for insertions of vertices that already exist
2022-11-08 17:11:22 +01:00
János Benjamin Antal
32fe4d94d9
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 16:35:38 +01:00
János Benjamin Antal
94b66a4e81
Merge pull request #638 from memgraph/T1148-MG-fix-expand-one-source-vertex
...
Fix setting the primary key of source vertex in ExpandOne
2022-11-08 16:35:30 +01:00
János Benjamin Antal
159b30ba5f
Merge branch 'project-pineapples' into T1148-MG-fix-expand-one-source-vertex
2022-11-08 08:20:25 +01:00
gvolfing
b67e5b9a6c
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 07:53:45 +01:00
gvolfing
79756ae6fb
Modify unit test
...
Instead of Creating an exception that is would be only used in this
file, just assert the type of the error the double vertex insertion
operation should yield.
2022-11-08 07:31:01 +01:00
gvolfing
91550128a5
Conform unit test with the new error-handling
2022-11-07 11:46:24 +01:00
jbajic
88487e2513
Extract vertex creation from FillUpSourceVertexSecondaryLabels
2022-11-07 10:54:28 +01:00
gvolfing
39b40ecf00
Extend the Error enum instead of a separate type
...
The error representing that a vertex is already inserted into the
skip-list was represented by the struct AlreadyInseertedElement. Instead
of using that struct, extend the memgraph::storage::v3::Error scoped
enum and use that to represent the double-insertion error.
2022-11-07 10:00:34 +01:00
Tyler Neely
d85fb94bc7
Merge pull request #634 from memgraph/T1122-MG-ShardManager-ThreadPool
...
Add shard manager thread pool
2022-11-04 16:41:53 +01:00
jbajic
4d2036249e
Fix e2e test
2022-11-04 16:37:35 +01:00
Jure Bajic
d23643d4ff
Merge branch 'project-pineapples' into T1148-MG-fix-expand-one-source-vertex
2022-11-04 16:19:55 +01:00
jbajic
e52ce1e363
Add expandone test
2022-11-04 16:18:18 +01:00
Tyler Neely
1abfe28806
Correctly use a moved transport interface while constructing CoordinatorWorker
2022-11-04 15:11:32 +00:00
Tyler Neely
528e30a9be
Avoid warning for not using captured this. Use std::move instead of forward where appropriate
2022-11-04 14:13:15 +00:00
Tyler Neely
bb7c7f7627
Make popped messages non-const to allow for RVO
2022-11-04 14:07:49 +00:00
jbajic
bab5e1386a
Address review comments
2022-11-04 15:05:55 +01:00
gvolfing
3d954e7abc
Restructure SchemaResult type and uts usage
...
Rename SchemaResult to ShardOperationResult move it into a separate
header and add a new type to the underlying variant that indicates that
the vertex, the user would like to insert into the skip-list already
exist.
2022-11-04 15:04:25 +01:00
Tyler Neely
fa5c9a2568
Make items popped from *worker::Queue const. Use std::move instead of std::forward in one place
2022-11-04 11:33:02 +00:00
Tyler Neely
c745f8c877
Fix build after breaking code suggestion
2022-11-04 11:32:17 +00:00
Tyler Neely
486231b1b9
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:28:01 +01:00
Tyler Neely
43ad5855c4
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:27:40 +01:00
Tyler Neely
24864ff7d2
Update src/coordinator/coordinator_worker.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com>
2022-11-04 12:17:57 +01:00
Tyler Neely
8598f6edf4
Fix a race condition that happens when logging from a detached thread in the cluster property test. Improve the ShardManager dtor and log statements
2022-11-04 11:14:39 +00:00
gvolfing
1cee7ecb8a
Make ShardRsm aware of trying to write the same vertex into the skip-list
2022-11-04 08:12:37 +01:00
Tyler Neely
9203616283
Merge branch 'project-pineapples' into T1122-MG-ShardManager-ThreadPool
2022-11-03 17:01:07 +01:00
Tyler Neely
d198819bf1
Merge pull request #637 from memgraph/tyler_remove_storage_v2_durability_test
...
Remove unit tests for storage v2
2022-11-03 17:00:46 +01:00
jbajic
3a8f01af79
Fix expand one source vertex pk setting
2022-11-03 16:29:28 +01:00
Tyler Neely
7e6ec8bb26
Capture this instead of all references in scope for call to std::visit to route CoordinatorWorker messages
2022-11-03 14:38:16 +00:00
Tyler Neely
6138d76690
Remove unit tests for storage v2
2022-11-03 14:21:17 +00:00
Tyler Neely
25fdb1a1f0
Make the high_density_shard_create_scan test run much faster
2022-11-03 13:48:11 +00:00
Tyler Neely
2de1d6c359
Fix UB due to integer overflow
2022-11-03 13:27:45 +00:00
Tyler Neely
0364311dd0
Log latency histograms in the high_density_shard_create_scan test
2022-11-03 12:44:47 +00:00
Tyler Neely
9235515dab
Reduce high_density_shard_create_scan shard+thread combinations. Log Raft write request demangled names
2022-11-03 12:38:12 +00:00
Tyler Neely
b83fb287ad
Apply feedback from clang-tidy
2022-11-03 11:00:07 +00:00
Tyler Neely
b685a21171
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-11-03 09:42:28 +00:00
Tyler Neely
4db83b8159
Add a few safety checks to the new concurrent Queue structures and the promise maps in the transport layer
2022-11-03 09:41:28 +00:00
Tyler Neely
dd8dd4f6c4
Restructure responsibilities for assigning request ids to the transport handles. Simplify promise tracking to avoid replier addresses, enabling eventual direct server return (DSR)
2022-11-03 09:31:06 +00:00
Tyler Neely
fa1ddfea12
Fix a bug where the MachineManager's destructor became incorrect after being moved
2022-11-02 17:45:27 +00:00
Tyler Neely
a815ec9617
Handle Coordinator work on a separate thread, unblocking the MachineManager to route additional messages to Shards
2022-11-02 17:15:52 +00:00
Tyler Neely
78528bd609
Avoid the ShutDown explicit acknowledgement due to jthread already blocking on this
2022-11-02 17:12:21 +00:00
Tyler Neely
6239f4fc3e
Simplify usage of PromiseKey in LocalTransportHandle to avoid replier address
2022-11-02 17:11:26 +00:00
János Benjamin Antal
9f71ce0f78
Merge pull request #635 from memgraph/MG-expand-fixes
2022-11-02 15:55:49 +01:00
János Benjamin Antal
589dd36bf2
Make function parameter constant
2022-11-02 14:44:54 +01:00
János Benjamin Antal
57e7169203
Eliminate dangling reference from lambda
2022-11-02 14:22:01 +01:00
János Benjamin Antal
bb3b053375
Create edge in the correct direction
2022-11-02 14:22:01 +01:00
János Benjamin Antal
a96f489756
Count the number of requests per operator
2022-11-02 14:22:01 +01:00