tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make items popped from *worker::Queue const. Use std::move instead of std::forward in one place

Browse Source
This commit is contained in:
Tyler Neely 2022-11-04 11:33:02 +00:00
parent c745f8c877
commit fa5c9a2568
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/coordinator/coordinator_worker.hpp
View File

@ -86,7 +86,7 @@ class Queue {
MG_ASSERT(inner_.use_count() > 0); MG_ASSERT(inner_.use_count() > 0);
std::unique_lock<std::mutex> lock(inner_->mu); std::unique_lock<std::mutex> lock(inner_->mu);
inner_->queue.emplace_back(std::forward<Message>(message)); inner_->queue.emplace_back(std::move(message));
} // lock dropped before notifying condition variable } // lock dropped before notifying condition variable
inner_->cv.notify_all(); inner_->cv.notify_all();
@ -100,7 +100,7 @@ class Queue {
inner_->cv.wait(lock); inner_->cv.wait(lock);
} }
Message message = std::move(inner_->queue.front()); const Message message = std::move(inner_->queue.front());
inner_->queue.pop_front(); inner_->queue.pop_front();
return message; return message;

2
src/storage/v3/shard_worker.hpp
View File

@ -109,7 +109,7 @@ class Queue {
inner_->cv.wait(lock); inner_->cv.wait(lock);
} }
Message message = std::move(inner_->queue.front()); const Message message = std::move(inner_->queue.front());
inner_->queue.pop_front(); inner_->queue.pop_front();
return message; return message;