From ebe3c74a8411e7162d1957161ec6369b9a767d71 Mon Sep 17 00:00:00 2001 From: Mislav Bradac Date: Mon, 16 Oct 2017 15:09:41 +0200 Subject: [PATCH] Cleanup skiplist insert_here method Reviewers: dgleich Reviewed By: dgleich Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D907 --- src/data_structures/concurrent/skiplist.hpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/data_structures/concurrent/skiplist.hpp b/src/data_structures/concurrent/skiplist.hpp index 5c65a4c0c..646a90a29 100644 --- a/src/data_structures/concurrent/skiplist.hpp +++ b/src/data_structures/concurrent/skiplist.hpp @@ -914,7 +914,7 @@ class SkipList : private Lockable { if (!lock_nodes(height, guards, preds, succs)) continue; return {insert_here(Node::create(std::forward(data), height), - preds, succs, height, guards), + preds, succs, height), true}; } } @@ -948,7 +948,7 @@ class SkipList : private Lockable { if (!lock_nodes(height, guards, preds, succs)) continue; return {insert_here(Node::emplace(height, std::forward(args)...), - preds, succs, height, guards), + preds, succs, height), true}; } } @@ -956,9 +956,8 @@ class SkipList : private Lockable { /** * Inserts data to specified locked location. */ - Iterator insert_here(Node *new_node, Node *preds[], Node *succs[], int height, - guard_t guards[]) { - // TODO: guards unused + Iterator insert_here(Node *new_node, Node *preds[], Node *succs[], + int height) { // link the predecessors and successors, e.g. // // 4 HEAD ... P ------------------------> S ... NULL