tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove vtable from TotalOrdering

Browse Source 
Summary: This change undoes the performance impact that was introduced in D1117

Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D1756
This commit is contained in:
Matej Ferencevic 2018-12-04 16:54:53 +01:00
parent 7a8e6b52e0
commit eabd832048
1 changed files with 3 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/utils/total_ordering.hpp
View File

@ -13,8 +13,10 @@ namespace utils {
*/
template <typename TLhs, typename TRhs = TLhs, typename TReturn = bool>
struct TotalOrdering {
virtual ~TotalOrdering() {}
protected:
~TotalOrdering() {}
public:
friend constexpr TReturn operator!=(const TLhs &a, const TRhs &b) {
return !(a == b);
}
@ -32,41 +34,4 @@ struct TotalOrdering {
}
};
template <class Derived, class T>
struct TotalOrderingWith {
virtual ~TotalOrderingWith() {}
friend constexpr bool operator!=(const Derived &a, const T &b) {
return !(a == b);
}
friend constexpr bool operator<=(const Derived &a, const T &b) {
return a < b || a == b;
}
friend constexpr bool operator>(const Derived &a, const T &b) {
return !(a <= b);
}
friend constexpr bool operator>=(const Derived &a, const T &b) {
return !(a < b);
}
friend constexpr bool operator!=(const T &a, const Derived &b) {
return !(a == b);
}
friend constexpr bool operator<=(const T &a, const Derived &b) {
return a < b || a == b;
}
friend constexpr bool operator>(const T &a, const Derived &b) {
return !(a <= b);
}
friend constexpr bool operator>=(const T &a, const Derived &b) {
return !(a < b);
}
};
} // namespace utils