tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Exit early on request vote if already voted

Browse Source 
Reviewers: msantl

Reviewed By: msantl

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D2098
This commit is contained in:
Ivan Paljak 2019-05-29 16:16:33 +02:00
parent 24ae8a759b
commit d6de4f4295
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/raft/raft_server.cpp
View File

@ -110,6 +110,14 @@ void RaftServer::Start() {
if (mode_ != Mode::FOLLOWER) Transition(Mode::FOLLOWER);
}
if (voted_for_) {
bool grant_vote = voted_for_.value() == req.candidate_id;
if (grant_vote) SetNextElectionTimePoint();
RequestVoteRes res(grant_vote, current_term_);
slk::Save(res, res_builder);
return;
}
// [Raft paper 5.2, 5.4]
// "Each server will vote for at most one candidate in a given
// term, on a first-come-first-serve basis with an additional
@ -118,7 +126,6 @@ void RaftServer::Start() {
// up-to-date than that of the candidate"
auto last_entry_data = LastEntryData();
bool grant_vote =
(!voted_for_ || voted_for_.value() == req.candidate_id) &&
AtLeastUpToDate(req.last_log_index, req.last_log_term,
last_entry_data.first, last_entry_data.second);
if (grant_vote) {