diff --git a/src/query/v2/multiframe.cpp b/src/query/v2/multiframe.cpp index 41ac7c6ed..904961213 100644 --- a/src/query/v2/multiframe.cpp +++ b/src/query/v2/multiframe.cpp @@ -62,6 +62,7 @@ void MultiFrame::DefragmentValidFrames() noexcept { in the range in such a way that the elements that are not to be removed appear in the beginning of the range. Relative order of the elements that remain is preserved and the physical size of the container is unchanged." */ + // NOLINTNEXTLINE (bugprone-unused-return-value) std::remove_if(frames_.begin(), frames_.end(), [](auto &frame) { return !frame.IsValid(); }); } diff --git a/src/query/v2/multiframe.hpp b/src/query/v2/multiframe.hpp index fae95ccca..a82c4a242 100644 --- a/src/query/v2/multiframe.hpp +++ b/src/query/v2/multiframe.hpp @@ -33,8 +33,8 @@ class MultiFrame { MultiFrame(int64_t size_of_frame, size_t number_of_frames, utils::MemoryResource *execution_memory); ~MultiFrame() = default; - MultiFrame(const MultiFrame &other); // copy constructor - MultiFrame(MultiFrame &&other) noexcept; // move constructor + MultiFrame(const MultiFrame &other); + MultiFrame(MultiFrame &&other) noexcept; MultiFrame &operator=(const MultiFrame &other) = delete; MultiFrame &operator=(MultiFrame &&other) noexcept = delete; @@ -96,10 +96,10 @@ class ValidFramesReader { explicit ValidFramesReader(MultiFrame &multiframe); ~ValidFramesReader() = default; - ValidFramesReader(const ValidFramesReader &other) = delete; // copy constructor - ValidFramesReader(ValidFramesReader &&other) noexcept = delete; // move constructor - ValidFramesReader &operator=(const ValidFramesReader &other) = delete; // copy assignment - ValidFramesReader &operator=(ValidFramesReader &&other) noexcept = delete; // move assignment + ValidFramesReader(const ValidFramesReader &other) = delete; + ValidFramesReader(ValidFramesReader &&other) noexcept = delete; + ValidFramesReader &operator=(const ValidFramesReader &other) = delete; + ValidFramesReader &operator=(ValidFramesReader &&other) noexcept = delete; struct Iterator { using iterator_category = std::forward_iterator_tag; @@ -165,7 +165,7 @@ class ValidFramesModifier { Iterator &operator++() { do { ptr_++; - } while (*this != iterator_wrapper_->end() && !this->ptr_->IsValid()); + } while (*this != iterator_wrapper_.end() && ptr_->IsValid()); return *this; }