From ca3f748325403771b4dbd02cbbda6551e88180f7 Mon Sep 17 00:00:00 2001
From: Tyler Neely <t@jujit.su>
Date: Mon, 5 Dec 2022 13:43:20 +0000
Subject: [PATCH] Apply clang-tidy feedback

---
 src/io/notifier.hpp             | 1 +
 src/query/v2/request_router.hpp | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/io/notifier.hpp b/src/io/notifier.hpp
index 9e0dec7df..e2b69e4ac 100644
--- a/src/io/notifier.hpp
+++ b/src/io/notifier.hpp
@@ -14,6 +14,7 @@
 #include <condition_variable>
 #include <functional>
 #include <mutex>
+#include <optional>
 #include <vector>
 
 namespace memgraph::io {
diff --git a/src/query/v2/request_router.hpp b/src/query/v2/request_router.hpp
index 0d4bf27e1..b38d4d005 100644
--- a/src/query/v2/request_router.hpp
+++ b/src/query/v2/request_router.hpp
@@ -359,7 +359,8 @@ class RequestRouter : public RequestRouterInterface {
 
   std::vector<msgs::GetPropertiesResultRow> GetProperties(msgs::GetPropertiesRequest requests) override {
     // create requests
-    std::vector<ShardRequestState<msgs::GetPropertiesRequest>> unsent_requests = RequestsForGetProperties(requests);
+    std::vector<ShardRequestState<msgs::GetPropertiesRequest>> unsent_requests =
+        RequestsForGetProperties(std::move(requests));
 
     // begin all requests in parallel
     RunningRequests<msgs::GetPropertiesRequest> running_requests = {};
@@ -530,14 +531,14 @@ class RequestRouter : public RequestRouterInterface {
   }
 
   std::vector<ShardRequestState<msgs::GetPropertiesRequest>> RequestsForGetProperties(
-      const msgs::GetPropertiesRequest &request) {
+      msgs::GetPropertiesRequest &&request) {
     std::map<Shard, msgs::GetPropertiesRequest> per_shard_request_table;
     auto top_level_rqst_template = request;
     top_level_rqst_template.transaction_id = transaction_id_;
     top_level_rqst_template.vertex_ids.clear();
     top_level_rqst_template.vertices_and_edges.clear();
 
-    for (auto &vertex : request.vertex_ids) {
+    for (auto &&vertex : request.vertex_ids) {
       auto shard =
           shards_map_.GetShardForKey(vertex.first.id, storage::conversions::ConvertPropertyVector(vertex.second));
       if (!per_shard_request_table.contains(shard)) {