From c15c16c5770fe0f67b470868ba9d7977c35b508a Mon Sep 17 00:00:00 2001 From: Lovro Lugovic Date: Wed, 6 Mar 2019 14:29:02 +0100 Subject: [PATCH] Prevent result accumulation within LCP's tests Summary: PROVE:PLAN clears the previously stored results for the current suite (which is the suite associated with the current package) and prevents "result accumulation" (and the accompanying huge and partly outdated reports). Reviewers: mtomic, teon.banek Reviewed By: teon.banek Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D1909 --- src/lisp/lcp-test.lisp | 2 -- src/lisp/lcp.asd | 5 ++++- tests/unit/test_lcp.lisp | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lisp/lcp-test.lisp b/src/lisp/lcp-test.lisp index 0592653ad..bf88720c0 100644 --- a/src/lisp/lcp-test.lisp +++ b/src/lisp/lcp-test.lisp @@ -24,8 +24,6 @@ (lcp::parse-cpp-type-declaration type-decl2) :test #'lcp::cpp-type=)) -(plan nil) - (deftest "supported" (subtest "designators" (mapc (lambda (sym) diff --git a/src/lisp/lcp.asd b/src/lisp/lcp.asd index 16e951f82..f48b3f088 100644 --- a/src/lisp/lcp.asd +++ b/src/lisp/lcp.asd @@ -15,4 +15,7 @@ (defsystem "lcp/test" :depends-on ("lcp" "prove") :components ((:file "lcp-test")) - :perform (test-op :after (op s) (symbol-call :prove :run-test-package :lcp-test))) + :perform (test-op :after (op s) + (let ((*package* (find-package :lcp-test))) + (symbol-call :prove :plan nil) + (symbol-call :prove :run-test-package :lcp-test)))) diff --git a/tests/unit/test_lcp.lisp b/tests/unit/test_lcp.lisp index 0b3ac08be..7e1869d02 100644 --- a/tests/unit/test_lcp.lisp +++ b/tests/unit/test_lcp.lisp @@ -8,6 +8,7 @@ (setf uiop:*image-entry-point* (lambda () (let ((prove:*default-reporter* :fiveam)) + (prove:plan nil) (unless (prove:run-test-package :lcp-test) (uiop:quit 1))))) (uiop:dump-image "test_lcp" :executable t)