From be7aa55686d49dbe57433e2d1424c5c32e78496c Mon Sep 17 00:00:00 2001
From: jeremy <jeremy.bailleux@memgraph.io>
Date: Fri, 28 Oct 2022 13:21:43 +0200
Subject: [PATCH] Add std::move

---
 src/storage/v3/shard_rsm.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/storage/v3/shard_rsm.cpp b/src/storage/v3/shard_rsm.cpp
index 105b3b3b4..8727c0440 100644
--- a/src/storage/v3/shard_rsm.cpp
+++ b/src/storage/v3/shard_rsm.cpp
@@ -276,7 +276,7 @@ std::optional<std::array<std::vector<EdgeAccessor>, 2>> FillUpConnectingEdges(
       break;
     }
   }
-  return std::array<std::vector<EdgeAccessor>, 2>{in_edges, out_edges};
+  return std::array<std::vector<EdgeAccessor>, 2>{std::move(in_edges), std::move(out_edges)};
 }
 
 using AllEdgePropertyDataSructure = std::map<PropertyId, msgs::Value>;
@@ -492,7 +492,7 @@ msgs::ReadResponses HandleReadWithOrderBy(msgs::ExpandOneRequest &&req, Shard::A
   auto maybe_filter_based_on_edge_uniquness = InitializeEdgeUniqunessFunction(req.only_unique_neighbor_rows);
   auto edge_filler = InitializeEdgeFillerFunction(req);
 
-  auto vertex_iterable = acc.Vertices(View::OLD);
+  auto vertex_iterable = acc.Vertices(View::OLD);  // #NoCommit we get all vertices in the DB here, is it wanted?
   const auto sorted_vertices = OrderByElements<VertexAccessor>(acc, dba, vertex_iterable, req.order_by);
 
   for (const auto &ordered_vertice : sorted_vertices) {
@@ -530,7 +530,8 @@ msgs::ReadResponses HandleReadWithOrderBy(msgs::ExpandOneRequest &&req, Shard::A
       break;
     }
 
-    msgs::VertexId src_vertice(msgs::Label{.id = *label_id}, conversions::ConvertValueVector(*primary_key));
+    msgs::VertexId src_vertice(msgs::Label{.id = *label_id},
+                               conversions::ConvertValueVector(*primary_key));  // #NoCommit rename
     auto maybe_result =
         GetExpandOneResult(src_vertex_acc, src_vertice, req, in_edge_ordered_accessors, out_edge_ordered_accessors,
                            maybe_filter_based_on_edge_uniquness, edge_filler);