tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve unit tests to catch bug

Browse Source
This commit is contained in:
János Benjamin Antal 2023-01-15 18:39:58 +01:00
parent b2b9b1d5cb
commit b30137ab7a
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/query/v2/requests.hpp
View File

@ -1,4 +1,4 @@
// Copyright 2022 Memgraph Ltd. // Copyright 2023 Memgraph Ltd.
// //
// Use of this software is governed by the Business Source License // Use of this software is governed by the Business Source License
// included in the file licenses/BSL.txt; by using this file, you agree to be bound by the terms of the Business Source // included in the file licenses/BSL.txt; by using this file, you agree to be bound by the terms of the Business Source
@ -36,6 +36,7 @@ struct Value;
struct Label { struct Label {
LabelId id; LabelId id;
friend bool operator==(const Label &lhs, const Label &rhs) { return lhs.id == rhs.id; } friend bool operator==(const Label &lhs, const Label &rhs) { return lhs.id == rhs.id; }
friend bool operator==(const Label &lhs, const LabelId &rhs) { return lhs.id == rhs; }
}; };
// TODO(kostasrim) update this with CompoundKey, same for the rest of the file. // TODO(kostasrim) update this with CompoundKey, same for the rest of the file.

18
tests/unit/query_v2_create_node_multiframe.cpp
View File

@ -36,15 +36,13 @@ MultiFrame CreateMultiFrame(const size_t max_pos) {
TEST(CreateNodeTest, CreateNodeCursor) { TEST(CreateNodeTest, CreateNodeCursor) {
using testing::_; using testing::_;
using testing::ElementsAre;
using testing::Return; using testing::Return;
AstStorage ast; AstStorage ast;
SymbolTable symbol_table; SymbolTable symbol_table;
plan::NodeCreationInfo node; plan::NodeCreationInfo node;
plan::EdgeCreationInfo edge;
edge.edge_type = msgs::EdgeTypeId::FromUint(1);
edge.direction = EdgeAtom::Direction::IN;
auto id_alloc = IdAllocator(0, 100); auto id_alloc = IdAllocator(0, 100);
node.symbol = symbol_table.CreateSymbol("n", true); node.symbol = symbol_table.CreateSymbol("n", true);
@ -67,5 +65,19 @@ TEST(CreateNodeTest, CreateNodeCursor) {
auto context = MakeContext(ast, symbol_table, &router, &id_alloc); auto context = MakeContext(ast, symbol_table, &router, &id_alloc);
auto multi_frame = CreateMultiFrame(context.symbol_table.max_position()); auto multi_frame = CreateMultiFrame(context.symbol_table.max_position());
cursor->PullMultiple(multi_frame, context); cursor->PullMultiple(multi_frame, context);
auto frames = multi_frame.GetValidFramesReader();
auto number_of_valid_frames = 0;
for (auto &frame : frames) {
++number_of_valid_frames;
EXPECT_EQ(frame[node.symbol].IsEdge(), true);
const auto &n = frame[node.symbol].ValueVertex();
EXPECT_THAT(n.Labels(), ElementsAre(msgs::Label{msgs::LabelId::FromUint(2)}));
}
EXPECT_EQ(number_of_valid_frames, 1);
auto invalid_frames = multi_frame.GetInvalidFramesPopulator();
auto number_of_invalid_frames = std::distance(invalid_frames.begin(), invalid_frames.end());
EXPECT_EQ(number_of_invalid_frames, 99);
} }
} // namespace memgraph::query::v2 } // namespace memgraph::query::v2