tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove copy constructor/assignment from utils::SpinLock

Browse Source 
Reviewers: teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D2581
This commit is contained in:
Matej Ferencevic 2019-12-04 13:26:21 +01:00
parent 0d979dd7b3
commit 9cc204793d
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/utils/spin_lock.hpp
View File

@ -28,6 +28,28 @@ class SpinLock {
<< "Couldn't construct utils::SpinLock!"; << "Couldn't construct utils::SpinLock!";
} }
SpinLock(SpinLock &&other) noexcept : lock_(other.lock_) {
CHECK(pthread_spin_init(&other.lock_, PTHREAD_PROCESS_PRIVATE) == 0)
<< "Couldn't construct utils::SpinLock!";
}
SpinLock &operator=(SpinLock &&other) noexcept {
CHECK(pthread_spin_destroy(&lock_) == 0)
<< "Couldn't destruct utils::SpinLock!";
lock_ = other.lock_;
CHECK(pthread_spin_init(&other.lock_, PTHREAD_PROCESS_PRIVATE) == 0)
<< "Couldn't construct utils::SpinLock!";
return *this;
}
SpinLock(const SpinLock &) = delete;
SpinLock &operator=(const SpinLock &) = delete;
~SpinLock() {
CHECK(pthread_spin_destroy(&lock_) == 0)
<< "Couldn't destruct utils::SpinLock!";
}
void lock() { void lock() {
// `pthread_spin_lock` returns -1 only when there is a deadlock detected // `pthread_spin_lock` returns -1 only when there is a deadlock detected
// (errno EDEADLOCK). // (errno EDEADLOCK).
@ -47,11 +69,6 @@ class SpinLock {
<< "Couldn't unlock utils::SpinLock!"; << "Couldn't unlock utils::SpinLock!";
} }
~SpinLock() {
CHECK(pthread_spin_destroy(&lock_) == 0)
<< "Couldn't destruct utils::SpinLock!";
}
private: private:
pthread_spinlock_t lock_; pthread_spinlock_t lock_;
}; };