tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix FLAGS_delta_chain_cache_threshold typo (#1181)

Browse Source
This commit is contained in:
Gareth Andrew Lloyd 2023-08-21 12:16:02 +01:00 committed by GitHub
parent adb65b2fff
commit 97183fb9da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/storage/v2/inmemory/indices_utils.hpp
View File

@ -202,7 +202,7 @@ inline bool CurrentVersionHasLabelProperty(const Vertex &vertex, LabelId label,
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction->manyDeltasCache;
cache.StoreExists(view, &vertex, exists);
cache.StoreDeleted(view, &vertex, deleted);

18
src/storage/v2/vertex_accessor.cpp
View File

@ -63,7 +63,7 @@ std::pair<bool, bool> IsVisible(Vertex const *vertex, Transaction const *transac
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction->manyDeltasCache;
cache.StoreExists(view, vertex, exists);
cache.StoreDeleted(view, vertex, deleted);
@ -163,7 +163,7 @@ Result<bool> VertexAccessor::HasLabel(LabelId label, View view) const {
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -210,7 +210,7 @@ Result<std::vector<LabelId>> VertexAccessor::Labels(View view) const {
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -340,7 +340,7 @@ Result<PropertyValue> VertexAccessor::GetProperty(PropertyId property, View view
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -388,7 +388,7 @@ Result<std::map<PropertyId, PropertyValue>> VertexAccessor::Properties(View view
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -465,7 +465,7 @@ Result<std::vector<EdgeAccessor>> VertexAccessor::InEdges(View view, const std::
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -539,7 +539,7 @@ Result<std::vector<EdgeAccessor>> VertexAccessor::OutEdges(View view, const std:
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -587,7 +587,7 @@ Result<size_t> VertexAccessor::InDegree(View view) const {
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);
@ -635,7 +635,7 @@ Result<size_t> VertexAccessor::OutDegree(View view) const {
// clang-format on
});
if (useCache && n_processed >= FLAGS_delta_chain_cache_threashold) {
if (useCache && n_processed >= FLAGS_delta_chain_cache_threshold) {
auto &cache = transaction_->manyDeltasCache;
cache.StoreExists(view, vertex_, exists);
cache.StoreDeleted(view, vertex_, deleted);

2
src/storage/v2/vertex_info_cache.cpp
View File

@ -16,7 +16,7 @@
#include "utils/flag_validation.hpp"
// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
DEFINE_VALIDATED_uint64(delta_chain_cache_threashold, 128,
DEFINE_VALIDATED_uint64(delta_chain_cache_threshold, 128,
"The threshold for when to cache long delta chains. This is used for heavy read + write "
"workloads where repeated processing of delta chains can become costly.",
{ return value > 0; });

2
src/storage/v2/vertex_info_cache.hpp
View File

@ -20,7 +20,7 @@
#include <gflags/gflags.h>
#include <tuple>
DECLARE_uint64(delta_chain_cache_threashold);
DECLARE_uint64(delta_chain_cache_threshold);
namespace memgraph::storage {

2
tests/e2e/configuration/default_config.py
View File

@ -202,7 +202,7 @@ startup_config_dict = {
"",
"The path to mappings that describes aliases to callables in cypher queries in the form of key-value pairs in a json file. With this option query module procedures that do not exist in memgraph can be mapped to ones that exist.",
),
"delta_chain_cache_threashold": (
"delta_chain_cache_threshold": (
"128",
"128",
"The threshold for when to cache long delta chains. This is used for heavy read + write workloads where repeated processing of delta chains can become costly.",