tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Further improve const-correctness and replace dispensable structured bindings with exact return values

Browse Source
This commit is contained in:
gvolfing 2022-08-01 15:30:44 +02:00
parent e905591372
commit 918fa7212e
1 changed files with 6 additions and 9 deletions

15
src/io/rsm/raft.hpp
View File

@ -246,8 +246,7 @@ class Raft {
return 0;
}
auto &[term, data] = state_.log.at(index - 1);
return term;
return state_.log.at(index - 1).first;
}
LogIndex CommittedLogIndex() { return state_.committed_log_size; }
@ -258,8 +257,7 @@ class Raft {
return 0;
}
auto &[term, data] = state_.log.at(state_.committed_log_size - 1);
return term;
return state_.log.at(state_.committed_log_size - 1).first;
}
LogIndex LastLogIndex() { return state_.log.size(); }
@ -269,8 +267,7 @@ class Raft {
return 0;
}
auto &[term, data] = state_.log.back();
return term;
return state_.log.back().first;
}
/// Periodic protocol maintenance.
@ -534,9 +531,9 @@ class Raft {
MG_ASSERT(req.term != state_.term, "Multiple leaders are acting under the term ", req.term);
}
bool is_candidate = std::is_same<AllRoles, Candidate>();
bool is_failed_competitor = is_candidate && req.term == state_.term;
Time now = io_.Now();
const bool is_candidate = std::is_same<AllRoles, Candidate>();
const bool is_failed_competitor = is_candidate && req.term == state_.term;
const Time now = io_.Now();
// Raft paper - 5.2
// While waiting for votes, a candidate may receive an