From 903ed3f25a9ccb16f402df05b8bd85e3a8179253 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ante=20Pu=C5=A1i=C4=87?= Date: Sun, 18 Feb 2024 15:53:12 +0100 Subject: [PATCH] Update notes --- src/dbms/inmemory/replication_handlers.cpp | 8 ++++---- src/storage/v2/replication/replication_client.cpp | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/dbms/inmemory/replication_handlers.cpp b/src/dbms/inmemory/replication_handlers.cpp index ee383a96f..329236ca0 100644 --- a/src/dbms/inmemory/replication_handlers.cpp +++ b/src/dbms/inmemory/replication_handlers.cpp @@ -539,7 +539,7 @@ uint64_t InMemoryReplicationHandlers::ReadAndApplyDelta(storage::InMemoryStorage auto vertex = transaction->FindVertex(delta.vertex_add_remove_label.gid, View::NEW); if (!vertex) throw utils::BasicException("Invalid transaction! Please raise an issue, {}:{}", __FILE__, __LINE__); - // NOTE: Phase 1 of the text search feature doesn't have replication in scope + // NOTE: Text search doesn’t have replication in scope yet (Phases 1 and 2) auto ret = vertex->AddLabel(transaction->NameToLabel(delta.vertex_add_remove_label.label)); if (ret.HasError() || !ret.GetValue()) throw utils::BasicException("Invalid transaction! Please raise an issue, {}:{}", __FILE__, __LINE__); @@ -552,7 +552,7 @@ uint64_t InMemoryReplicationHandlers::ReadAndApplyDelta(storage::InMemoryStorage auto vertex = transaction->FindVertex(delta.vertex_add_remove_label.gid, View::NEW); if (!vertex) throw utils::BasicException("Invalid transaction! Please raise an issue, {}:{}", __FILE__, __LINE__); - // NOTE: Phase 1 of the text search feature doesn't have replication in scope + // NOTE: Text search doesn’t have replication in scope yet (Phases 1 and 2) auto ret = vertex->RemoveLabel(transaction->NameToLabel(delta.vertex_add_remove_label.label)); if (ret.HasError() || !ret.GetValue()) throw utils::BasicException("Invalid transaction! Please raise an issue, {}:{}", __FILE__, __LINE__); @@ -767,11 +767,11 @@ uint64_t InMemoryReplicationHandlers::ReadAndApplyDelta(storage::InMemoryStorage break; } case WalDeltaData::Type::TEXT_INDEX_CREATE: { - // NOTE: Phase 1 of the text search feature doesn't have replication in scope + // NOTE: Text search doesn’t have replication in scope yet (Phases 1 and 2) break; } case WalDeltaData::Type::TEXT_INDEX_DROP: { - // NOTE: Phase 1 of the text search feature doesn't have replication in scope + // NOTE: Text search doesn’t have replication in scope yet (Phases 1 and 2) break; } case WalDeltaData::Type::EXISTENCE_CONSTRAINT_CREATE: { diff --git a/src/storage/v2/replication/replication_client.cpp b/src/storage/v2/replication/replication_client.cpp index 16247de57..a59fa95b1 100644 --- a/src/storage/v2/replication/replication_client.cpp +++ b/src/storage/v2/replication/replication_client.cpp @@ -354,7 +354,8 @@ void ReplicaStream::AppendOperation(durability::StorageMetadataOperation operati const std::set &properties, const LabelIndexStats &stats, const LabelPropertyIndexStats &property_stats, uint64_t timestamp) { replication::Encoder encoder(stream_.GetBuilder()); - EncodeOperation(&encoder, storage_->name_id_mapper_.get(), operation, label, properties, stats, property_stats, + // NOTE: Text search doesn’t have replication in scope yet (Phases 1 and 2) -> text index name not sent here + EncodeOperation(&encoder, storage_->name_id_mapper_.get(), operation, "", label, properties, stats, property_stats, timestamp); }