tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tune multipool sizes

Browse Source
This commit is contained in:
Gareth Lloyd 2024-03-11 13:23:27 +00:00
parent 51301a8125
commit 853dfe3c65
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/utils/memory.cpp
View File

@ -154,13 +154,13 @@ Pool::Pool(size_t block_size, unsigned char blocks_per_chunk, MemoryResource *ch
: blocks_per_chunk_(blocks_per_chunk),
block_size_(block_size),
data_size_{blocks_per_chunk_ * block_size_},
alignment_{Ceil2(block_size_)},
chunks_(chunk_memory) {
// Use the next pow2 of block_size_ as alignment, so that we cover alignment
// requests between 1 and block_size_. Users of this class should make sure
// that requested alignment of particular blocks is never greater than the
// block itself.
if (block_size_ > std::numeric_limits<size_t>::max() / blocks_per_chunk_) throw BadAlloc("Allocation size overflow");
alignment_ = Ceil2(block_size_);
if (alignment_ < block_size_) throw BadAlloc("Allocation alignment overflow");
}
@ -381,10 +381,10 @@ void *PoolResource2::DoAllocate(size_t bytes, size_t alignment) {
// as malloc/free.
if (block_size % alignment != 0) throw BadAlloc("Requested bytes must be a multiple of alignment");
if (pools_4bit_.is_above_upper_bound(block_size)) return unpooled_memory_->Allocate(bytes, alignment);
if (pools_2bit_.is_size_handled(block_size)) return pools_2bit_.allocate(block_size);
if (pools_5bit_.is_above_upper_bound(block_size)) return unpooled_memory_->Allocate(bytes, alignment);
if (pools_3bit_.is_size_handled(block_size)) return pools_3bit_.allocate(block_size);
if (pools_4bit_.is_size_handled(block_size)) return pools_4bit_.allocate(block_size);
if (pools_5bit_.is_size_handled(block_size)) return pools_5bit_.allocate(block_size);
DMG_ASSERT(block_size <= 8);
return pool_8_.Allocate();
}
@ -392,14 +392,14 @@ void PoolResource2::DoDeallocate(void *p, size_t bytes, size_t alignment) {
size_t block_size = std::max(bytes, alignment);
DMG_ASSERT(block_size % alignment == 0);
if (pools_4bit_.is_above_upper_bound(block_size)) {
if (pools_5bit_.is_above_upper_bound(block_size)) {
unpooled_memory_->Deallocate(p, bytes, alignment);
} else if (pools_2bit_.is_size_handled(block_size)) {
pools_2bit_.deallocate(p, block_size);
} else if (pools_3bit_.is_size_handled(block_size)) {
pools_3bit_.deallocate(p, block_size);
} else if (pools_4bit_.is_size_handled(block_size)) {
pools_4bit_.deallocate(p, block_size);
} else if (pools_5bit_.is_size_handled(block_size)) {
pools_5bit_.deallocate(p, block_size);
} else {
DMG_ASSERT(block_size <= 8);
pool_8_.Deallocate(p);

8
src/utils/memory.hpp
View File

@ -595,9 +595,9 @@ class PoolResource2 final : public MemoryResource {
PoolResource2(uint8_t blocks_per_chunk, MemoryResource *memory = NewDeleteResource(),
MemoryResource *internal_memory = NewDeleteResource())
: pool_8_(8, blocks_per_chunk, memory),
pools_2bit_(blocks_per_chunk, memory, internal_memory),
pools_3bit_(blocks_per_chunk, memory, internal_memory),
pools_4bit_(blocks_per_chunk, memory, internal_memory),
pools_5bit_(blocks_per_chunk, memory, internal_memory),
unpooled_memory_{internal_memory} {}
~PoolResource2() override = default;
@ -608,9 +608,9 @@ class PoolResource2 final : public MemoryResource {
private:
impl::Pool pool_8_;
impl::MultiPool<2, 8, 128> pools_2bit_;
impl::MultiPool<3, 128, 512> pools_3bit_;
impl::MultiPool<4, 512, 1024> pools_4bit_;
impl::MultiPool<3, 8, 128> pools_3bit_;
impl::MultiPool<4, 128, 512> pools_4bit_;
impl::MultiPool<5, 512, 1024> pools_5bit_;
MemoryResource *unpooled_memory_;
};