Update outdated comments
This commit is contained in:
parent
c04cfc5596
commit
7fb828bca3
@ -217,9 +217,7 @@ class DistributedCreateNodeCursor : public Cursor {
|
|||||||
msgs::NewVertex rqst;
|
msgs::NewVertex rqst;
|
||||||
MG_ASSERT(!node_info_.labels.empty(), "Cannot determine primary label");
|
MG_ASSERT(!node_info_.labels.empty(), "Cannot determine primary label");
|
||||||
const auto primary_label = node_info_.labels[0];
|
const auto primary_label = node_info_.labels[0];
|
||||||
// TODO(jbajic) Fix properties not send,
|
// TODO(jbajic) Send also the properties that are not part of primary key
|
||||||
// suggestion: ignore distinction between properties and primary keys
|
|
||||||
// since schema validation is done on storage side
|
|
||||||
ExpressionEvaluator evaluator(&frame, context.symbol_table, context.evaluation_context, nullptr,
|
ExpressionEvaluator evaluator(&frame, context.symbol_table, context.evaluation_context, nullptr,
|
||||||
storage::v3::View::NEW);
|
storage::v3::View::NEW);
|
||||||
if (const auto *node_info_properties = std::get_if<PropertiesMapList>(&node_info_.properties)) {
|
if (const auto *node_info_properties = std::get_if<PropertiesMapList>(&node_info_.properties)) {
|
||||||
@ -272,9 +270,7 @@ class DistributedCreateNodeCursor : public Cursor {
|
|||||||
MG_ASSERT(!node_info_.labels.empty(), "Cannot determine primary label");
|
MG_ASSERT(!node_info_.labels.empty(), "Cannot determine primary label");
|
||||||
const auto primary_label = node_info_.labels[0];
|
const auto primary_label = node_info_.labels[0];
|
||||||
MG_ASSERT(context.request_router->IsPrimaryLabel(primary_label), "First label has to be a primary label!");
|
MG_ASSERT(context.request_router->IsPrimaryLabel(primary_label), "First label has to be a primary label!");
|
||||||
// TODO(jbajic) Fix properties not send,
|
// TODO(jbajic) Send also the properties that are not part of primary key
|
||||||
// suggestion: ignore distinction between properties and primary keys
|
|
||||||
// since schema validation is done on storage side
|
|
||||||
ExpressionEvaluator evaluator(&frame, context.symbol_table, context.evaluation_context, nullptr,
|
ExpressionEvaluator evaluator(&frame, context.symbol_table, context.evaluation_context, nullptr,
|
||||||
storage::v3::View::NEW);
|
storage::v3::View::NEW);
|
||||||
if (const auto *node_info_properties = std::get_if<PropertiesMapList>(&node_info_.properties)) {
|
if (const auto *node_info_properties = std::get_if<PropertiesMapList>(&node_info_.properties)) {
|
||||||
|
Loading…
Reference in New Issue
Block a user