From 7ceeb3bc6d750c527401ba4c0b7846a01f2ca5db Mon Sep 17 00:00:00 2001
From: imilinovic <ivan.milinovic123@gmail.com>
Date: Wed, 13 Mar 2024 13:01:07 +0100
Subject: [PATCH] rollback transaction on failed commit
---
src/storage/v2/disk/storage.cpp | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/storage/v2/disk/storage.cpp b/src/storage/v2/disk/storage.cpp
index 21ae7755e..78122d0e1 100644
--- a/src/storage/v2/disk/storage.cpp
+++ b/src/storage/v2/disk/storage.cpp
@@ -1761,6 +1761,10 @@ utils::BasicResult<StorageManipulationError, void> DiskStorage::DiskAccessor::Co
logging::AssertRocksDBStatus(transaction_.disk_transaction_->SetCommitTimestamp(*commit_timestamp_));
}
auto commitStatus = transaction_.disk_transaction_->Commit();
+
+ if (!commitStatus.ok()) {
+ transaction_.disk_transaction_->Rollback();
+ }
delete transaction_.disk_transaction_;
transaction_.disk_transaction_ = nullptr;
if (!commitStatus.ok()) {