tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix double free

Browse Source 
Summary: It was possible for transaction to be double freed because both the AllClear and SingleClear of transactions could delete the pointer

Reviewers: florijan, mferencevic

Reviewed By: mferencevic

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D1250
This commit is contained in:
Dominik Gleich 2018-02-27 13:55:23 +01:00
parent a826f41444
commit 79dc10960e
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/transactions/engine_worker.cpp
View File

@ -134,8 +134,10 @@ void WorkerEngine::ClearTransactionalCache(
auto access = active_.access(); auto access = active_.access();
for (auto kv : access) { for (auto kv : access) {
if (kv.first < oldest_active) { if (kv.first < oldest_active) {
delete kv.second; auto transaction_ptr = kv.second;
access.remove(kv.first); if (access.remove(kv.first)) {
delete transaction_ptr;
}
} }
} }
} }
@ -144,8 +146,10 @@ void WorkerEngine::ClearSingleTransaction(transaction_id_t tx_id) const {
auto access = active_.access(); auto access = active_.access();
auto found = access.find(tx_id); auto found = access.find(tx_id);
if (found != access.end()) { if (found != access.end()) {
delete found->second; auto transaction_ptr = found->second;
access.remove(found->first); if (access.remove(found->first)) {
delete transaction_ptr;
}
} }
} }