tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add duration support for timestamp function (#236)

Browse Source
This commit is contained in:
Kostas Kyrimis 2021-09-15 19:05:30 +03:00 committed by Antonio Andelic
parent b45ae403e6
commit 738b5fb8d8
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/query/interpret/awesome_memgraph_functions.cpp
View File

@ -88,6 +88,7 @@ struct Path {};
struct Date {};
struct LocalTime {};
struct LocalDateTime {};
struct Duration {};
template <class ArgType>
bool ArgIsType(const TypedValue &arg) {
@ -125,6 +126,8 @@ bool ArgIsType(const TypedValue &arg) {
return arg.IsLocalTime();
} else if constexpr (std::is_same_v<ArgType, LocalDateTime>) {
return arg.IsLocalDateTime();
} else if constexpr (std::is_same_v<ArgType, Duration>) {
return arg.IsDuration();
} else if constexpr (std::is_same_v<ArgType, void>) {
return true;
} else {
@ -173,6 +176,8 @@ constexpr const char *ArgTypeName() {
return "LocalTime";
} else if constexpr (std::is_same_v<ArgType, LocalDateTime>) {
return "LocalDateTime";
} else if constexpr (std::is_same_v<ArgType, Duration>) {
return "Duration";
} else {
static_assert(std::is_same_v<ArgType, Null>, "Unknown ArgType");
}
@ -881,7 +886,7 @@ TypedValue ToString(const TypedValue *args, int64_t nargs, const FunctionContext
}
TypedValue Timestamp(const TypedValue *args, int64_t nargs, const FunctionContext &ctx) {
FType<Optional<Or<Date, LocalTime, LocalDateTime>>>("timestamp", args, nargs);
FType<Optional<Or<Date, LocalTime, LocalDateTime, Duration>>>("timestamp", args, nargs);
const auto &arg = *args;
if (arg.IsDate()) {
return TypedValue(arg.ValueDate().MicrosecondsSinceEpoch(), ctx.memory);
@ -892,6 +897,9 @@ TypedValue Timestamp(const TypedValue *args, int64_t nargs, const FunctionContex
if (arg.IsLocalDateTime()) {
return TypedValue(arg.ValueLocalDateTime().MicrosecondsSinceEpoch(), ctx.memory);
}
if (arg.IsDuration()) {
return TypedValue(arg.ValueDuration().microseconds, ctx.memory);
}
return TypedValue(ctx.timestamp, ctx.memory);
}

6
tests/unit/query_expression_evaluator.cpp
View File

@ -1762,6 +1762,12 @@ TEST_F(FunctionTest, TimestampLocalDateTime) {
EXPECT_EQ(EvaluateFunction("TIMESTAMP", time).ValueInt(), 20000);
}
TEST_F(FunctionTest, TimestampDuration) {
ctx.timestamp = 42;
const utils::Duration time(20000);
EXPECT_EQ(EvaluateFunction("TIMESTAMP", time).ValueInt(), 20000);
}
TEST_F(FunctionTest, TimestampExceptions) {
ctx.timestamp = 42;
EXPECT_THROW(EvaluateFunction("TIMESTAMP", 1).ValueInt(), QueryRuntimeException);