tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set [[nodiscard]] attribute on storage::Result

Browse Source 
Reviewers: mtomic, mferencevic

Reviewed By: mferencevic

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D2214
This commit is contained in:
Teon Banek 2019-07-17 10:57:31 +02:00
parent e7b1d1aa0c
commit 59b3f84eb9
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/storage/v2/result.hpp
View File

@ -13,7 +13,7 @@ enum class Error : uint8_t {
}; };
template <typename TValue> template <typename TValue>
class Result final { class [[nodiscard]] Result final {
public: public:
explicit Result(const TValue &value) : value_(value) {} explicit Result(const TValue &value) : value_(value) {}
explicit Result(TValue &&value) : value_(std::move(value)) {} explicit Result(TValue &&value) : value_(std::move(value)) {}

13
tests/unit/storage_v2_gc.cpp
View File

@ -32,7 +32,7 @@ TEST(StorageV2Gc, Sanity) {
auto vertex = acc.FindVertex(vertices[i], storage::View::OLD); auto vertex = acc.FindVertex(vertices[i], storage::View::OLD);
ASSERT_TRUE(vertex.has_value()); ASSERT_TRUE(vertex.has_value());
if (i % 5 == 0) { if (i % 5 == 0) {
acc.DeleteVertex(&vertex.value()); EXPECT_FALSE(acc.DeleteVertex(&vertex.value()).HasError());
} }
} }
@ -57,9 +57,9 @@ TEST(StorageV2Gc, Sanity) {
EXPECT_EQ(vertex.has_value(), i % 5 != 0); EXPECT_EQ(vertex.has_value(), i % 5 != 0);
if (vertex.has_value()) { if (vertex.has_value()) {
vertex->AddLabel(3 * i); EXPECT_FALSE(vertex->AddLabel(3 * i).HasError());
vertex->AddLabel(3 * i + 1); EXPECT_FALSE(vertex->AddLabel(3 * i + 1).HasError());
vertex->AddLabel(3 * i + 2); EXPECT_FALSE(vertex->AddLabel(3 * i + 2).HasError());
} }
} }
@ -97,7 +97,8 @@ TEST(StorageV2Gc, Sanity) {
EXPECT_EQ(to_vertex.has_value(), (i + 1) % 5 != 0); EXPECT_EQ(to_vertex.has_value(), (i + 1) % 5 != 0);
if (from_vertex.has_value() && to_vertex.has_value()) { if (from_vertex.has_value() && to_vertex.has_value()) {
acc.CreateEdge(&from_vertex.value(), &to_vertex.value(), i); EXPECT_FALSE(acc.CreateEdge(&from_vertex.value(), &to_vertex.value(), i)
.HasError());
} }
} }
@ -107,7 +108,7 @@ TEST(StorageV2Gc, Sanity) {
EXPECT_EQ(vertex.has_value(), i % 5 != 0); EXPECT_EQ(vertex.has_value(), i % 5 != 0);
if (vertex.has_value()) { if (vertex.has_value()) {
if (i % 3 == 0) { if (i % 3 == 0) {
acc.DetachDeleteVertex(&vertex.value()); EXPECT_FALSE(acc.DetachDeleteVertex(&vertex.value()).HasError());
} }
} }
} }