tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make index creation fully parallel

Browse Source 
Summary:
Testing on following operations:

UNWIND RANGE(0,1000000) AS _ CREATE (n: Node {a: 1.0, b:2.0});
CREATE INDEX ON :Node(a);
CREATE INDEX ON :Node(b);

Before:
~32sec

After:
~18sec

Reviewers: mislav.bradac, florijan

Reviewed By: florijan

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D1041
This commit is contained in:
Dominik Gleich 2017-12-13 15:54:27 +01:00
parent 4da8312abe
commit 581404a7b6
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/database/graph_db_accessor.cpp
View File

@ -101,8 +101,9 @@ void GraphDbAccessor::BuildIndex(const GraphDbTypes::Label &label,
db_.index_build_tx_in_progress_.access().insert(transaction_->id_);
// on function exit switch the build_in_progress to false
utils::OnScopeExit on_exit([this] {
// on function exit remove the create index transaction from
// build_tx_in_progress
utils::OnScopeExit on_exit_1([this] {
auto removed =
db_.index_build_tx_in_progress_.access().remove(transaction_->id_);
DCHECK(removed) << "Index creation transaction should be inside set";
@ -139,6 +140,18 @@ void GraphDbAccessor::BuildIndex(const GraphDbTypes::Label &label,
// This accessor's transaction surely sees everything that happened before
// CreateIndex.
GraphDbAccessor dba(db_);
// Add transaction to the build_tx_in_progress as this transaction doesn't
// change data and shouldn't block other parallel index creations
auto read_transaction_id = dba.transaction().id_;
db_.index_build_tx_in_progress_.access().insert(read_transaction_id);
// on function exit remove the read transaction from build_tx_in_progress
utils::OnScopeExit on_exit_2([read_transaction_id, this] {
auto removed =
db_.index_build_tx_in_progress_.access().remove(read_transaction_id);
DCHECK(removed) << "Index building (read) transaction should be inside set";
});
for (auto vertex : dba.Vertices(label, false)) {
db_.label_property_index_.UpdateOnLabelProperty(vertex.address().local(),
vertex.current_);