Remove rechecking external projects
Summary: This is probably a bug in CMake. When the external projects are forced to be rechecked, CPack takes their outputs and puts them in binary release. Since rechecking is removed, this means that any changes to external projects (like gflags or glog) will not be recompiled with plain `make all`. You need to call `make clean` first. The same applies to catching configuration like removal of filenames in glog when creating a release build. Reviewers: mferencevic Reviewed By: mferencevic Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D890
This commit is contained in:
parent
93b9592c63
commit
57144518d0
@ -56,12 +56,6 @@ function(add_external_project name)
|
||||
-DCMAKE_INSTALL_PREFIX=${source_dir}
|
||||
${KW_CMAKE_ARGS}
|
||||
INSTALL_COMMAND ${KW_INSTALL_COMMAND})
|
||||
# Force the build step (which will check if the source changed) by removing
|
||||
# the stamped build file.
|
||||
ExternalProject_Add_Step(
|
||||
${name}-proj force-build
|
||||
COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_BINARY_DIR}/src/${name}-proj-stamp/${name}-proj-build
|
||||
DEPENDERS configure ALWAYS 1)
|
||||
endfunction(add_external_project)
|
||||
|
||||
# Calls `add_external_project`, sets NAME_LIBRARY, NAME_INCLUDE_DIR variables
|
||||
|
Loading…
Reference in New Issue
Block a user