Use correct memory resource (#900)

This commit is contained in:
János Benjamin Antal 2023-04-26 10:02:55 +02:00 committed by GitHub
parent 6c947947eb
commit 4fcdd52f88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1068,14 +1068,14 @@ std::optional<plan::ProfilingStatsWithTotalTime> PullPlan::Pull(AnyStream *strea
std::optional<utils::PoolResource> pool_memory; std::optional<utils::PoolResource> pool_memory;
if (!use_monotonic_memory_) { if (!use_monotonic_memory_) {
pool_memory.emplace(8, kExecutionPoolMaxBlockSize, utils::NewDeleteResource(), utils::NewDeleteResource()); pool_memory.emplace(8, kExecutionPoolMaxBlockSize, &resource_with_exception, &resource_with_exception);
} else { } else {
// We can throw on every query because a simple queries for deleting will use only // We can throw on every query because a simple queries for deleting will use only
// the stack allocated buffer. // the stack allocated buffer.
// Also, we want to throw only when the query engine requests more memory and not the storage // Also, we want to throw only when the query engine requests more memory and not the storage
// so we add the exception to the allocator. // so we add the exception to the allocator.
// TODO (mferencevic): Tune the parameters accordingly. // TODO (mferencevic): Tune the parameters accordingly.
pool_memory.emplace(128, 1024, &monotonic_memory, utils::NewDeleteResource()); pool_memory.emplace(128, 1024, &monotonic_memory, &resource_with_exception);
} }
std::optional<utils::LimitedMemoryResource> maybe_limited_resource; std::optional<utils::LimitedMemoryResource> maybe_limited_resource;