tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve SHOW INDEX INFO for text indices

Browse Source
This commit is contained in:
Ante Pušić 2024-02-27 08:08:48 +01:00
parent 3c46929204
commit 4bdcb3320e
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/query/interpreter.cpp
View File

@ -3541,7 +3541,7 @@ PreparedQuery PrepareDatabaseInfoQuery(ParsedQuery parsed_query, bool in_explici
} }
MG_ASSERT(current_db.db_acc_, "Database info query expects a current DB"); MG_ASSERT(current_db.db_acc_, "Database info query expects a current DB");
MG_ASSERT(current_db.db_transactional_accessor_, "Database ifo query expects a current DB transaction"); MG_ASSERT(current_db.db_transactional_accessor_, "Database info query expects a current DB transaction");
auto *dba = &*current_db.execution_db_accessor_; auto *dba = &*current_db.execution_db_accessor_;
auto *info_query = utils::Downcast<DatabaseInfoQuery>(parsed_query.query); auto *info_query = utils::Downcast<DatabaseInfoQuery>(parsed_query.query);
@ -3570,8 +3570,9 @@ PreparedQuery PrepareDatabaseInfoQuery(ParsedQuery parsed_query, bool in_explici
TypedValue(storage->PropertyToName(item.second)), TypedValue(storage->PropertyToName(item.second)),
TypedValue(static_cast<int>(storage_acc->ApproximateVertexCount(item.first, item.second)))}); TypedValue(static_cast<int>(storage_acc->ApproximateVertexCount(item.first, item.second)))});
} }
for (const auto &item : info.text_indices) { for (const auto &[index_name, label] : info.text_indices) {
results.push_back({TypedValue(text_index_mark), TypedValue(item.first), TypedValue(), TypedValue()}); results.push_back({TypedValue(fmt::format("{} (name: {})", text_index_mark, index_name)),
TypedValue(storage->LabelToName(label)), TypedValue(), TypedValue()});
} }
std::sort(results.begin(), results.end(), [&label_index_mark](const auto &record_1, const auto &record_2) { std::sort(results.begin(), results.end(), [&label_index_mark](const auto &record_1, const auto &record_2) {
const auto type_1 = record_1[0].ValueString(); const auto type_1 = record_1[0].ValueString();

4
tests/e2e/text_search/test_text_search.py
View File

@ -28,7 +28,9 @@ def test_create_index(memgraph):
index_info = memgraph.execute_and_fetch("""SHOW INDEX INFO""") index_info = memgraph.execute_and_fetch("""SHOW INDEX INFO""")
assert list(index_info) == [{"index type": "text", "label": "exampleIndex", "property": None, "count": None}] assert list(index_info) == [
{"index type": "text (name: exampleIndex)", "label": "Document", "property": None, "count": None}
]
def test_drop_index(memgraph): def test_drop_index(memgraph):