tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix unnecessary multiple inserts.

Browse Source 
Summary: Unnecessary inserts into skiplist. Skiplist when calls insert alredy blocks untill it inserts or finds that record.

Reviewers: mislav.bradac, teon.banek

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D210
This commit is contained in:
Dominik Gleich 2017-03-31 13:47:09 +02:00
parent 67d916e459
commit 4a6d17658c
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/database/graph_db_accessor.cpp
View File

@ -41,14 +41,8 @@ VertexAccessor GraphDbAccessor::insert_vertex() {
Vertex *vertex = nullptr;
auto vertex_vlist = new mvcc::VersionList<Vertex>(*transaction_, vertex);
// insert the newly created record into the main storage
// TODO make the number of tries configurable
for (int i = 0; i < 5; ++i) {
bool success = db_.vertices_.access().insert(vertex_vlist).second;
if (success) return VertexAccessor(*vertex_vlist, *vertex, *this);
// TODO sleep for some configurable amount of time
}
bool success = db_.vertices_.access().insert(vertex_vlist).second;
if (success) return VertexAccessor(*vertex_vlist, *vertex, *this);
throw CreationException("Unable to create a Vertex after 5 attempts");
}
@ -82,13 +76,8 @@ EdgeAccessor GraphDbAccessor::insert_edge(VertexAccessor &from,
from.update().out_.emplace_back(edge_vlist);
to.update().in_.emplace_back(edge_vlist);
// insert the newly created record into the main storage
// TODO make the number of tries configurable
for (int i = 0; i < 5; ++i) {
bool success = db_.edges_.access().insert(edge_vlist).second;
if (success) return EdgeAccessor(*edge_vlist, *edge, *this);
// TODO sleep for some amount of time
}
bool success = db_.edges_.access().insert(edge_vlist).second;
if (success) return EdgeAccessor(*edge_vlist, *edge, *this);
throw CreationException("Unable to create an Edge after 5 attempts");
}