tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix flaky GC test (#1619)

Browse Source
This commit is contained in:
Ivan Milinović 2024-01-10 00:11:29 +01:00 committed by GitHub
parent 4bb9238679
commit 1ba2f4e619
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/e2e/garbage_collection/gc_periodic.py
View File

@ -38,21 +38,21 @@ def get_memory(cursor):
def test_gc_periodic(connection): def test_gc_periodic(connection):
"""
This test checks that periodic gc works.
It does so by checking that the allocated memory is lowered by at least 1/4 of the memory allocated by creating nodes.
If we choose a number a high number the test will become flaky because the memory only gets fully cleared after a while
due to jemalloc holding some memory for a while. If we'd wait for jemalloc to fully release the memory the test would take too long.
"""
cursor = connection.cursor() cursor = connection.cursor()
memory_pre_creation = get_memory(cursor) memory_pre_creation = get_memory(cursor)
execute_and_fetch_all(cursor, "UNWIND range(1, 1000) AS index CREATE (:Node);") execute_and_fetch_all(cursor, "UNWIND range(1, 100000) AS index CREATE (:Node);")
memory_after_creation = get_memory(cursor) memory_after_creation = get_memory(cursor)
time.sleep(5) execute_and_fetch_all(cursor, "MATCH (n) DETACH DELETE n;")
for i in range(5):
time.sleep(2)
memory_after_gc = get_memory(cursor) memory_after_gc = get_memory(cursor)
assert memory_after_gc < memory_pre_creation + (memory_after_creation - memory_pre_creation) / 4 * 3 if memory_after_gc < memory_pre_creation + (memory_after_creation - memory_pre_creation) / 4:
return
raise MemoryError("GC didn't clean the memory after 10 seconds")
if __name__ == "__main__": if __name__ == "__main__":