Make ConvertPropertyMap expect ref and not rvalue

This commit is contained in:
jeremy 2022-11-22 14:01:16 +01:00
parent ce8bc522d0
commit 1101c2444c
2 changed files with 2 additions and 2 deletions

View File

@ -66,7 +66,7 @@ msgs::WriteResponses ShardRsm::ApplyWrite(msgs::CreateVerticesRequest &&req) {
/// TODO(gvolfing) Consider other methods than converting. Change either
/// the way that the property map is stored in the messages, or the
/// signature of CreateVertexAndValidate.
auto converted_property_map = ConvertPropertyMap(std::move(new_vertex.properties));
auto converted_property_map = ConvertPropertyMap(new_vertex.properties);
// TODO(gvolfing) make sure if this conversion is actually needed.
std::vector<LabelId> converted_label_ids;

View File

@ -131,7 +131,7 @@ inline msgs::VertexId ToMsgsVertexId(const v3::VertexId &vertex_id) {
}
inline std::vector<std::pair<v3::PropertyId, v3::PropertyValue>> ConvertPropertyMap(
std::vector<std::pair<v3::PropertyId, Value>> &&properties) {
std::vector<std::pair<v3::PropertyId, Value>> &properties) {
std::vector<std::pair<v3::PropertyId, v3::PropertyValue>> ret;
ret.reserve(properties.size());