tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Copy accumulated elements in Synchronize

Browse Source 
Summary:
The row elements must not be moved, because the following pulls may
still use them.

Reviewers: mtomic, llugovic, mferencevic

Reviewed By: llugovic, mferencevic

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D1672
This commit is contained in:
Teon Banek 2018-10-17 17:05:44 +02:00
parent 18eee6337c
commit 0829b2bb90
1 changed files with 2 additions and 6 deletions

8
src/query/plan/distributed_ops.cpp
View File

@ -557,12 +557,8 @@ class SynchronizeCursor : public Cursor {
// Accumulate local results
while (input_cursor_->Pull(frame, context)) {
local_frames_.emplace_back();
auto &local_frame = local_frames_.back();
local_frame.reserve(frame.elems().size());
for (auto &elem : frame.elems()) {
local_frame.emplace_back(std::move(elem));
}
// Copy the frame elements, because Pull may still use them.
local_frames_.emplace_back(frame.elems());
}
// Wait for all workers to finish accumulation (first sync point).