tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Implement toString function

Browse Source 
Summary: https://neo4j.com/docs/developer-manual/3.4/cypher/functions/string/#functions-tostring

Reviewers: teon.banek, buda

Reviewed By: teon.banek

Subscribers: pullbot

Differential Revision: https://phabricator.memgraph.io/D1430
This commit is contained in:
Marin Tomic 2018-06-15 10:40:51 +02:00
parent b017283bfb
commit 054c127175
2 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/query/interpret/awesome_memgraph_functions.cpp
View File

@ -655,6 +655,29 @@ TypedValue Id(const std::vector<TypedValue> &args,
}
}
TypedValue ToString(const std::vector<TypedValue> &args,
database::GraphDbAccessor &) {
if (args.size() != 1U) {
throw QueryRuntimeException("toString takes one argument");
}
auto &arg = args[0];
switch (arg.type()) {
case TypedValue::Type::Null:
return TypedValue::Null;
case TypedValue::Type::String:
return arg;
case TypedValue::Type::Int:
return std::to_string(arg.ValueInt());
case TypedValue::Type::Double:
return std::to_string(arg.ValueDouble());
case TypedValue::Type::Bool:
return arg.ValueBool() ? "true" : "false";
default:
throw QueryRuntimeException(
"toString argument must be a number, string or boolean");
}
}
} // namespace
std::function<TypedValue(const std::vector<TypedValue> &,
@ -706,6 +729,7 @@ NameToFunction(const std::string &function_name) {
if (function_name == "INDEXINFO") return IndexInfo;
if (function_name == "WORKERID") return WorkerId;
if (function_name == "ID") return Id;
if (function_name == "TOSTRING") return ToString;
return nullptr;
}
} // namespace query

44
tests/unit/query_expression_evaluator.cpp
View File

@ -1424,4 +1424,48 @@ TEST(ExpressionEvaluator, FunctionWorkerIdSingleNode) {
EXPECT_EQ(EvaluateFunction("WORKERID", {va}, db).Value<int64_t>(),
db.WorkerId());
}
TEST(ExpressionEvaluator, FunctionToStringNull) {
database::SingleNode db;
EXPECT_TRUE(EvaluateFunction("TOSTRING", {TypedValue::Null}, db).IsNull());
}
TEST(ExpressionEvaluator, FunctionToStringString) {
database::SingleNode db;
EXPECT_EQ(EvaluateFunction("TOSTRING", {""}, db).ValueString(), "");
EXPECT_EQ(
EvaluateFunction("TOSTRING", {"this is a string"}, db).ValueString(),
"this is a string");
}
TEST(ExpressionEvaluator, FunctionToStringInteger) {
database::SingleNode db;
EXPECT_EQ(EvaluateFunction("TOSTRING", {-23321312}, db).ValueString(),
"-23321312");
EXPECT_EQ(EvaluateFunction("TOSTRING", {0}, db).ValueString(), "0");
EXPECT_EQ(EvaluateFunction("TOSTRING", {42}, db).ValueString(), "42");
}
TEST(ExpressionEvaluator, FunctionToStringDouble) {
database::SingleNode db;
EXPECT_EQ(EvaluateFunction("TOSTRING", {-42.42}, db).ValueString(),
"-42.420000");
EXPECT_EQ(EvaluateFunction("TOSTRING", {0.0}, db).ValueString(), "0.000000");
EXPECT_EQ(EvaluateFunction("TOSTRING", {238910.2313217}, db).ValueString(),
"238910.231322");
}
TEST(ExpressionEvaluator, FunctionToStringBool) {
database::SingleNode db;
EXPECT_EQ(EvaluateFunction("TOSTRING", {true}, db).ValueString(), "true");
EXPECT_EQ(EvaluateFunction("TOSTRING", {false}, db).ValueString(), "false");
}
TEST(ExpressionEvaluator, FunctionToStringExceptions) {
database::SingleNode db;
EXPECT_THROW(EvaluateFunction("TOSTRING", {1, 2, 3}, db),
QueryRuntimeException);
std::vector<TypedValue> l{1, 2, 3};
EXPECT_THROW(EvaluateFunction("TOSTRING", l, db), QueryRuntimeException);
}
} // namespace