Address review comments

This commit is contained in:
jbajic 2022-11-14 09:15:03 +01:00
parent 6eabceca4a
commit 0462b8fc8f
4 changed files with 21 additions and 5 deletions

View File

@ -452,7 +452,7 @@ struct ExpandOneResponse {
struct UpdateVertex {
PrimaryKey primary_key;
// This should be a map
// Labels are first added and then removed from vertices
std::vector<LabelId> add_labels;
std::vector<LabelId> remove_labels;
std::map<PropertyId, Value> property_updates;

View File

@ -107,7 +107,7 @@ void LogResultError(const ResultErrorType &error, const std::string_view action)
break;
}
} else {
static_assert(kAlwaysFalse<T>, "Missing type from variant visitor");
static_assert(utils::kAlwaysFalse<T>, "Missing type from variant visitor");
}
},
error);

View File

@ -15,12 +15,10 @@
#include "storage/v3/bindings/typed_value.hpp"
#include "storage/v3/shard.hpp"
#include "storage/v3/vertex_accessor.hpp"
#include "utils/template_utils.hpp"
namespace memgraph::storage::v3 {
template <typename>
constexpr auto kAlwaysFalse{false};
inline bool TypedValueCompare(const TypedValue &a, const TypedValue &b) {
// in ordering null comes after everything else
// at the same time Null is not less that null

View File

@ -0,0 +1,18 @@
// Copyright 2022 Memgraph Ltd.
//
// Use of this software is governed by the Business Source License
// included in the file licenses/BSL.txt; by using this file, you agree to be bound by the terms of the Business Source
// License, and you may not use this file except in compliance with the Business Source License.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0, included in the file
// licenses/APL.txt.
#pragma once
namespace memgraph::utils {
template <typename>
constexpr auto kAlwaysFalse{false};
} // namespace memgraph::utils