memgraph/tests/unit/database_master.cpp

#include "gtest/gtest.h"

#include "config.hpp"
#include "database/distributed_graph_db.hpp"

TEST(DatabaseMaster, Instantiate) {
  database::Config config;
  config.master_endpoint = io::network::Endpoint("127.0.0.1", 0);
  config.worker_id = 0;
  database::Master master(config);
}
Add database master test Summary: Seperate rpc server names Reviewers: florijan, teon.banek Reviewed By: florijan Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D1118 2018-01-19 20:39:18 +08:00			`#include "gtest/gtest.h"`

			`#include "config.hpp"`
Split GraphDb to distributed and single node files Summary: This change, hopefully, simplifies the implementation of different kinds of GraphDb. The pimpl idiom is now simplified by removing all of the crazy inheritance. Implementations classes are just plain data stores, without any methods. The interface classes now have a more flat hierarchy: ``` GraphDb (pure interface) \| +----+---------- DistributedGraphDb (pure interface) \| \| Single Node +-----+------+ \| \| Master Worker ``` DistributedGraphDb is used as an intermediate interface for all the things that should work only in distributed. Therefore, virtual calls for distributed stuff have been removed from GraphDb. Some are exposed via DistributedGraphDb, other's are only in concrete Master and Worker classes. The code which relied on those virtual calls has been refactored to either use DistributedGraphDb, take a pointer to what is actually needed or use dynamic_cast. Obviously, dynamic_cast is a temporary solution and should be replaced with another mechanism (e.g. virtual call, or some other function pointer style). The cost of the above change is some code duplication in constructors and destructors of classes. This duplication has a lot of little tweaks that make it hard to generalize, not to mention that virtual calls do not work in constructor and destructor. If we really care about generalizing this, we should think about abandoning RAII in favor of constructor + Init method. The next steps for splitting the dependencies that seem logical are: 1) Split GraphDbAccessor implementation, either via inheritance or passing in an implementation pointer. GraphDbAccessor should then only be created by a virtual call on GraphDb. 2) Split Interpreter implementation. Besides allowing single node interpreter to exist without depending on distributed, this will enable the planner and operators to be correctly separated. Reviewers: msantl, mferencevic, ipaljak Reviewed By: msantl Subscribers: dgleich, pullbot Differential Revision: https://phabricator.memgraph.io/D1493 2018-07-19 23:00:50 +08:00			`#include "database/distributed_graph_db.hpp"`
Add database master test Summary: Seperate rpc server names Reviewers: florijan, teon.banek Reviewed By: florijan Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D1118 2018-01-19 20:39:18 +08:00
			`TEST(DatabaseMaster, Instantiate) {`
			`database::Config config;`
			`config.master_endpoint = io::network::Endpoint("127.0.0.1", 0);`
			`config.worker_id = 0;`
			`database::Master master(config);`
			`}`