From 6d5898aa99d6282f6bfb9bef2bbf8ac5dbd28ebd Mon Sep 17 00:00:00 2001 From: Marco Munizaga Date: Thu, 23 Jun 2022 15:33:12 -0700 Subject: [PATCH] Use bytes rather than decbytes (power of 2) --- obs/grafana-dashboards/resource-manager.json | 8 ++++---- obs/stats.go | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/obs/grafana-dashboards/resource-manager.json b/obs/grafana-dashboards/resource-manager.json index 66d390a..f2fabfe 100644 --- a/obs/grafana-dashboards/resource-manager.json +++ b/obs/grafana-dashboards/resource-manager.json @@ -1224,7 +1224,7 @@ } ] }, - "unit": "decbytes" + "unit": "bytes" }, "overrides": [] }, @@ -1311,7 +1311,7 @@ } ] }, - "unit": "decbytes" + "unit": "bytes" }, "overrides": [] }, @@ -1398,7 +1398,7 @@ } ] }, - "unit": "decbytes" + "unit": "bytes" }, "overrides": [] }, @@ -1485,7 +1485,7 @@ } ] }, - "unit": "decbytes" + "unit": "bytes" }, "overrides": [ { diff --git a/obs/stats.go b/obs/stats.go index 89dc5b5..262028b 100644 --- a/obs/stats.go +++ b/obs/stats.go @@ -329,9 +329,6 @@ func (r StatsTraceReporter) ConsumeEvent(evt rcmgr.TraceEvt) { tags := []tag.Mutator{tag.Upsert(Scope, scope), tag.Upsert(Resource, resource)} - // TODO fix the graph in the dashboard for blocked resources. - // TODO change bytes to iec - if evt.DeltaIn != 0 { stats.RecordWithTags(ctx, tags, blockedResources.M(int64(1))) }