libp2p/go-libp2p-peerstore
1
0
Fork 0
mirror of https://github.com/libp2p/go-libp2p-peerstore.git synced 2025-02-10 06:50:15 +08:00
Code Issues Projects Releases Wiki Activity

panic when peer ID validation fails

Browse Source
This commit is contained in:
Marten Seemann 2021-12-04 16:53:56 +04:00
parent 8afd0b8898
commit e5ba90639c
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pstoremem/metadata.go
View File

@ -3,7 +3,7 @@ package pstoremem
import ( import (
"sync" "sync"
peer "github.com/libp2p/go-libp2p-core/peer" "github.com/libp2p/go-libp2p-core/peer"
pstore "github.com/libp2p/go-libp2p-core/peerstore" pstore "github.com/libp2p/go-libp2p-core/peerstore"
) )
@ -19,7 +19,7 @@ type metakey struct {
type memoryPeerMetadata struct { type memoryPeerMetadata struct {
// store other data, like versions // store other data, like versions
//ds ds.ThreadSafeDatastore // ds ds.ThreadSafeDatastore
ds map[metakey]interface{} ds map[metakey]interface{}
dslock sync.RWMutex dslock sync.RWMutex
interned map[string]interface{} interned map[string]interface{}
@ -36,7 +36,7 @@ func NewPeerMetadata() *memoryPeerMetadata {
func (ps *memoryPeerMetadata) Put(p peer.ID, key string, val interface{}) error { func (ps *memoryPeerMetadata) Put(p peer.ID, key string, val interface{}) error {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return err panic(err)
} }
ps.dslock.Lock() ps.dslock.Lock()
defer ps.dslock.Unlock() defer ps.dslock.Unlock()
@ -53,7 +53,7 @@ func (ps *memoryPeerMetadata) Put(p peer.ID, key string, val interface{}) error
func (ps *memoryPeerMetadata) Get(p peer.ID, key string) (interface{}, error) { func (ps *memoryPeerMetadata) Get(p peer.ID, key string) (interface{}, error) {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return nil, err panic(err)
} }
ps.dslock.RLock() ps.dslock.RLock()
defer ps.dslock.RUnlock() defer ps.dslock.RUnlock()

12
pstoremem/protobook.go
View File

@ -83,7 +83,7 @@ func (pb *memoryProtoBook) internProtocol(proto string) string {
func (pb *memoryProtoBook) SetProtocols(p peer.ID, protos ...string) error { func (pb *memoryProtoBook) SetProtocols(p peer.ID, protos ...string) error {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return err panic(err)
} }
if len(protos) > pb.maxProtos { if len(protos) > pb.maxProtos {
return errTooManyProtocols return errTooManyProtocols
@ -104,7 +104,7 @@ func (pb *memoryProtoBook) SetProtocols(p peer.ID, protos ...string) error {
func (pb *memoryProtoBook) AddProtocols(p peer.ID, protos ...string) error { func (pb *memoryProtoBook) AddProtocols(p peer.ID, protos ...string) error {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return err panic(err)
} }
s := pb.segments.get(p) s := pb.segments.get(p)
@ -128,7 +128,7 @@ func (pb *memoryProtoBook) AddProtocols(p peer.ID, protos ...string) error {
func (pb *memoryProtoBook) GetProtocols(p peer.ID) ([]string, error) { func (pb *memoryProtoBook) GetProtocols(p peer.ID) ([]string, error) {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return nil, err panic(err)
} }
s := pb.segments.get(p) s := pb.segments.get(p)
@ -145,7 +145,7 @@ func (pb *memoryProtoBook) GetProtocols(p peer.ID) ([]string, error) {
func (pb *memoryProtoBook) RemoveProtocols(p peer.ID, protos ...string) error { func (pb *memoryProtoBook) RemoveProtocols(p peer.ID, protos ...string) error {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return err panic(err)
} }
s := pb.segments.get(p) s := pb.segments.get(p)
@ -166,7 +166,7 @@ func (pb *memoryProtoBook) RemoveProtocols(p peer.ID, protos ...string) error {
func (pb *memoryProtoBook) SupportsProtocols(p peer.ID, protos ...string) ([]string, error) { func (pb *memoryProtoBook) SupportsProtocols(p peer.ID, protos ...string) ([]string, error) {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return nil, err panic(err)
} }
s := pb.segments.get(p) s := pb.segments.get(p)
@ -185,7 +185,7 @@ func (pb *memoryProtoBook) SupportsProtocols(p peer.ID, protos ...string) ([]str
func (pb *memoryProtoBook) FirstSupportedProtocol(p peer.ID, protos ...string) (string, error) { func (pb *memoryProtoBook) FirstSupportedProtocol(p peer.ID, protos ...string) (string, error) {
if err := p.Validate(); err != nil { if err := p.Validate(); err != nil {
return "", err panic(err)
} }
s := pb.segments.get(p) s := pb.segments.get(p)