Commit Graph

65 Commits

Author SHA1 Message Date
Raúl Kripalani
d17a62c365 move protobuf files; adjust imports everywhere. 2019-12-27 20:26:08 +00:00
Raúl Kripalani
9a771f9d94 move envelope to record package. 2019-12-27 20:09:43 +00:00
Raúl Kripalani
9bbe26ca5f envelope: use byte slices from pool; adjust interface. 2019-12-27 20:07:28 +00:00
Yusef Napora
1d207a334e rm stray ref to golang/protobuf 2019-12-20 16:14:10 -05:00
Yusef Napora
f24669b805 fix: rebuild protos with new gogofaster generator 2019-12-20 16:14:10 -05:00
Yusef Napora
982d6a05fe use camelCase in protos for consistency 2019-12-20 16:13:11 -05:00
Yusef Napora
6d57752bb9 use multiformats uvarint for length-prefixes 2019-12-20 16:13:11 -05:00
Yusef Napora
5887c40119 expose struct fields & remove accessors 2019-12-20 16:13:11 -05:00
Yusef Napora
b0f6ab1b9f whitespace 2019-12-20 16:13:11 -05:00
Yusef Napora
e8ab218f27 get rid of unsigned RoutingState struct, only expose SignedRoutingState 2019-12-20 16:13:11 -05:00
Yusef Napora
8f13c6042b use test helpers 2019-12-20 16:13:11 -05:00
Yusef Napora
08da615203 rename Equals -> Equal, add some comments 2019-12-20 16:13:11 -05:00
Yusef Napora
1274af3f6e tests for RoutingState 2019-12-20 16:13:11 -05:00
Yusef Napora
647b39f3e3 use buffer pool for envelope signatures 2019-12-20 16:13:11 -05:00
Yusef Napora
6014637275 make envelope fields private & validate on unmarshal 2019-12-20 16:13:11 -05:00
Yusef Napora
9cc8ee1b44 use proto3 & rename fields to match spec changes 2019-12-20 16:13:11 -05:00
Yusef Napora
8996a208d9 go fmt 2019-12-20 16:13:11 -05:00
Yusef Napora
10ff6fca32 tests for SignedEnvelopes 2019-12-20 16:11:40 -05:00
Yusef Napora
38bf94611f doc comments for envelopes 2019-12-20 16:11:40 -05:00
Yusef Napora
7dd3a0884c use struct for SignedEnvelope instead of exposing protobuf directly 2019-12-20 16:11:40 -05:00
Yusef Napora
e6ef922b7b add SignedEnvelope type 2019-12-20 16:11:40 -05:00
Dmitry Yu Okunev
205fb711b9 Use standard library "crypto/ed25519" 2019-12-06 21:58:31 -05:00
Steven Allen
54a9d30499
Merge pull request #56 from JorikSchellekens/patch-1
Fix documentation missmatch for crypto methods.
2019-12-06 21:50:47 -05:00
Steven Allen
11af061e49 chore(dep): update protobuf 2019-10-28 13:07:54 -07:00
Steven Allen
bf79471ef0 fix(key size): forbid small openssl RSA keys
Also, add a test.
2019-10-21 15:52:27 -07:00
Mike Goelzer
e331ba838c
Comment that KeyStretcher is pre-deprecation 2019-09-30 09:58:09 -07:00
Steven Allen
0c42806002
Merge pull request #59 from adam-hanna/master
adds ability to create keys from crypto.PrivateKey types
2019-09-30 09:23:17 -07:00
Steven Allen
469ed581a0
Merge pull request #48 from libp2p/fix/fallback-cmp
fix: use fallback comparison for ed25519 keys
2019-09-27 15:33:55 -07:00
Steven Allen
c3facda1a2 crypto: use basicEquals for ECDSA
The check was incomplete as it didn't test the curve. This switches us to use
basicEquals (which is also constant-time).

Note: This key type isn't used by anyone in-practice (to the best of my
knowledge).
2019-09-24 10:41:53 -07:00
Steven Allen
d68e65376d crypto: make the ECDSA receiver consistent 2019-09-24 10:41:53 -07:00
Steven Allen
947196bbb7 crypto: use constant time compare when decoding private keys
In practice, this is impossible to exploit without being able to corrupt the
private key which would allow a much simpler guess-and-check attack. However,
it's still a bad practice to compare private key material like this.
2019-09-24 10:40:54 -07:00
adam
2b32a36d90
incorporates code review comments from @raulk; changes KeyPairFromKey to KeyPairFromStdKey and improves godoc. 2019-09-20 23:37:38 -07:00
adam
23811ec09b
fixes typo 2019-09-19 16:24:24 -07:00
adam
316b0af70d
incorporates code review from @Stebalien 2019-09-19 16:21:08 -07:00
adam
0468ff83df
adds ability to create keys from crypto.PrivateKey types 2019-09-19 15:16:52 -07:00
Jorik Schellekens
dd55087854
The docs seem to lie
The docs seem to lie about what these methods do.
This is the naive solution since it's my first day looking
at go but would it be possible to get these methods
to marshal to public or private key correctly by passing
a type to them?
2019-09-04 13:53:57 +01:00
Cole Brown
d50ea9bc1f Ensure all tests pass without weak RSA key flag 2019-08-28 11:34:22 -04:00
bigs
9698a72f45
Merge pull request #31 from libp2p/bug/remove-blowfish-support
Remove support for blowfish
2019-08-06 12:29:59 -04:00
Cole Brown
47983a3ab5 Add test for panic on unknown cipher type 2019-08-06 12:15:40 -04:00
Cole Brown
58281f5c6d Add note about panic to KeyStretcher comments 2019-08-06 11:18:41 -04:00
Steven Allen
1461eb16af fix: use fallback comparison for ed25519 keys 2019-08-01 17:45:55 -07:00
Steven Allen
543dbe6c29 nit: simplify equality check 2019-08-01 16:37:58 -07:00
Steven Allen
963cc997b2 remove non-constant-time private key comparison 2019-08-01 16:37:58 -07:00
Steven Allen
9a4415d1a6 use a fallback basicEquals function everywhere
This also ensures we check that the types are equal, even if we're comparing
directly with `k1.Equals(k2)` instead of `KeyEquals(k1, k2)`.
2019-08-01 16:37:58 -07:00
dignifiedquire
2df9672ee4 use equal method from openssl
uses https://github.com/spacemonkeygo/openssl/pull/126
2019-08-01 16:37:58 -07:00
dignifiedquire
bab5f6dd95 fixup: openssl 2019-08-01 16:37:30 -07:00
dignifiedquire
da42c385fc fix: do not allocate when comparing keys 2019-08-01 16:37:30 -07:00
bigs
a7cc4bffb1
Merge pull request #34 from libp2p/bug/weak-rsa-keys
Raise minimum bits required for RSA key to 2048
2019-08-01 15:28:04 -08:00
Cole Brown
f1175dbc91 Rename constant for weak RSA key environment variable 2019-08-01 19:05:47 -04:00
Cole Brown
d95ff26e5e UNSAFE -> WEAK in RSA key environment variable 2019-08-01 13:57:48 -04:00