libp2p/go-libp2p-core
1
0
Fork 0
mirror of https://github.com/libp2p/go-libp2p-core.git synced 2025-04-17 15:40:37 +08:00
Code Issues Projects Releases Wiki Activity

cleaner test structure

Browse Source
This commit is contained in:
Mantas Vidutis 2019-05-31 11:16:03 -07:00
parent ce1f5da199
commit ffa6afe144
1 changed files with 12 additions and 15 deletions

27
metrics/register_test.go
View File

@ -8,13 +8,6 @@ import (
"go.opencensus.io/stats/view"
)
func testWrapper(t *testing.T, f func(t *testing.T)) func(t *testing.T) {
for k, _ := range registeredViews {
delete(registeredViews, k)
}
return f
}
func newTestMeasure(name string) stats.Measure {
return stats.Int64(fmt.Sprintf("test/measure/%s", name),
fmt.Sprintf("Test measurement %s", name),
@ -32,15 +25,19 @@ func newTestView(name string) view.View {
}
func TestRegisteringViews(t *testing.T) {
t.Run("test registering first views", testWrapper(t, func(t *testing.T) {
for k, _ := range registeredViews {
delete(registeredViews, k)
}
t.Run("test registering first views", func(t *testing.T) {
testView := newTestView("empty-map-0")
if err := RegisterViews("test", &testView); err != nil {
t.Fatal("unable to register view in empty map", err)
}
}))
})
t.Run("test registering with existing views", testWrapper(t, func(t *testing.T) {
t.Run("test registering with existing views", func(t *testing.T) {
testView := newTestView("empty-map-1")
testView2 := newTestView("existing-entity-0")
@ -50,9 +47,9 @@ func TestRegisteringViews(t *testing.T) {
if err := RegisterViews("test3", &testView2); err != nil {
t.Fatal("unable to register view in map", err)
}
}))
})
t.Run("test registering duplicate views", testWrapper(t, func(t *testing.T) {
t.Run("test registering duplicate views", func(t *testing.T) {
testView := newTestView("empty-map-2")
testView2 := newTestView("existing-entity-1")
@ -62,9 +59,9 @@ func TestRegisteringViews(t *testing.T) {
if err := RegisterViews("test4", &testView2); err == nil {
t.Fatal("allowed duplicate view registration")
}
}))
})
t.Run("test looking up views", testWrapper(t, func(t *testing.T) {
t.Run("test looking up views", func(t *testing.T) {
testView := newTestView("empty-map-3")
if err := RegisterViews("test5", &testView); err != nil {
@ -79,5 +76,5 @@ func TestRegisteringViews(t *testing.T) {
if views[0].Name != testView.Name {
t.Fatal("incorrect view lookup, received name:", views[0].Name)
}
}))
})
}