libp2p/go-libp2p-core
1
0
Fork 0
mirror of https://github.com/libp2p/go-libp2p-core.git synced 2025-01-29 04:40:10 +08:00
Code Issues Projects Releases Wiki Activity

Compare multihash Code to IDENTITY when extracting public key

Browse Source 
This PR is a non-substantive change with the goal of making this method
`ExtractPublicKey` from a `peer.ID` clearer to the reader. This goal is
accomplished by using the full name of the identity hash code `IDENTITY` instead
of the deprecated `ID` code. This change makes its clearer to the reader that
there is a trivial way to compute the public key given the digest. Without this
change it is easy to confuse `ID` with a concept relating to peer IDs (and thus
implying this function somehow computes a hash pre-image to get the
corrresponding public key.
This commit is contained in:
Alex Stokes 2019-08-14 14:27:04 -07:00
parent d204016fc6
commit 686c1736fd
No known key found for this signature in database
GPG Key ID: 51CE1721B245C086
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
peer/peer.go
View File

@ -92,7 +92,7 @@ func (id ID) ExtractPublicKey() (ic.PubKey, error) {
if err != nil {
return nil, err
}
if decoded.Code != mh.ID {
if decoded.Code != mh.IDENTITY {
return nil, ErrNoPublicKey
}
pk, err := ic.UnmarshalPublicKey(decoded.Digest)