github-repos/wget
1
0
Fork 0
mirror of https://github.com/mirror/wget.git synced 2025-01-05 09:50:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

* src/http.c (set_file_timestamp): Remove use of alloca

Browse Source
This commit is contained in:
Tim Rühsen 2020-02-13 15:30:50 +01:00
parent f460e1d049
commit e22dbe5af0
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/http.c
View File

@ -2228,8 +2228,6 @@ establish_connection (const struct url *u, const struct url **conn_ref,
static uerr_t
set_file_timestamp (struct http_stat *hs)
{
size_t filename_len = strlen (hs->local_file);
char *filename_plus_orig_suffix = alloca (filename_len + sizeof (ORIG_SFX));
bool local_dot_orig_file_exists = false;
char *local_filename = NULL;
struct stat st;
@ -2242,6 +2240,15 @@ set_file_timestamp (struct http_stat *hs)
_wasn't_ specified last time, or the server contains files called
*.orig, -N will be back to not operating correctly with -k. */
{
char buf[1024];
size_t filename_len = strlen (hs->local_file);
char *filename_plus_orig_suffix;
if (filename_len + sizeof (ORIG_SFX) > sizeof (buf))
filename_plus_orig_suffix = xmalloc (filename_len + sizeof (ORIG_SFX));
else
filename_plus_orig_suffix = buf;
/* Would a single s[n]printf() call be faster? --dan
Definitely not. sprintf() is horribly slow. It's a