From 70f7cdf1af06adaaac906d92cdb78938838f144a Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano <gscrivan@redhat.com>
Date: Sun, 29 Dec 2013 11:46:04 +0100
Subject: [PATCH] Remove some useless if statements
---
src/ChangeLog | 7 +++++++
src/init.c | 3 +--
src/warc.c | 16 ++++++----------
3 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index b3766ced..3d6699cb 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2013-12-29 Giuseppe Scrivano <gscrivan@redhat.com>
+
+ * init.c (home_dir): Remove useless 'if'.
+ * warc.c (warc_start_new_file): Likewise.
+ (warc_process_cdx_line): Likewise.
+ (warc_write_response_record): Likewise.
+
2013-12-26 Tim Ruehsen <tim.ruehsen@gmx.de>
* gnutls.c (ssl_connect_wget): Fix connect timeout failure
diff --git a/src/init.c b/src/init.c
index 84ae654c..a64dabe6 100644
--- a/src/init.c
+++ b/src/init.c
@@ -462,8 +462,7 @@ home_dir (void)
}
ret = home ? xstrdup (home) : NULL;
- if (buf)
- free (buf);
+ free (buf);
return ret;
}
diff --git a/src/warc.c b/src/warc.c
index 41f522af..c3a58572 100644
--- a/src/warc.c
+++ b/src/warc.c
@@ -726,10 +726,9 @@ warc_start_new_file (bool meta)
if (warc_current_file != NULL)
fclose (warc_current_file);
- if (warc_current_warcinfo_uuid_str)
- free (warc_current_warcinfo_uuid_str);
- if (warc_current_filename)
- free (warc_current_filename);
+
+ free (warc_current_warcinfo_uuid_str);
+ free (warc_current_filename);
warc_current_file_number++;
@@ -918,8 +917,7 @@ warc_process_cdx_line (char *lineptr, int field_num_original_url,
else
{
free (original_url);
- if (checksum_v != NULL)
- free (checksum_v);
+ free (checksum_v);
free (record_id);
}
}
@@ -1417,10 +1415,8 @@ warc_write_response_record (char *url, char *timestamp_str,
response_uuid);
}
- if (block_digest)
- free (block_digest);
- if (payload_digest)
- free (payload_digest);
+ free (block_digest);
+ free (payload_digest);
return warc_write_ok;
}