github-repos/wget
1
0
Fork 0
mirror of https://github.com/mirror/wget.git synced 2025-01-05 09:50:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

* src/http-ntlm.c (ntlm_input): Replace alloca by fixed length array

Browse Source
This commit is contained in:
Tim Rühsen 2020-02-12 16:44:59 +01:00
parent c65c23cfc7
commit 1ebd88063d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/http-ntlm.c
View File

@ -118,17 +118,17 @@ ntlm_input (struct ntlmdata *ntlm, const char *header)
32 (48) start of data block
*/
ssize_t size;
char *buffer = (char *) alloca (strlen (header));
char buffer[48]; // decode 48 bytes needs ((48 + 2) / 3) * 4 + 1 bytes
DEBUGP (("Received a type-2 NTLM message.\n"));
size = wget_base64_decode (header, buffer, strlen (header));
size = wget_base64_decode (header, buffer, sizeof (buffer));
if (size < 0)
return false; /* malformed base64 from server */
ntlm->state = NTLMSTATE_TYPE2; /* we got a type-2 */
if (size >= 48)
if ((size_t) size >= sizeof (buffer))
/* the nonce of interest is index [24 .. 31], 8 bytes */
memcpy (ntlm->nonce, &buffer[24], 8);