github-repos/tinycc
1
0
Fork 0
mirror of https://github.com/mirror/tinycc.git synced 2025-03-26 12:04:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

x86-64: Prefer 32S relocations

Browse Source 
This target has _32 and _32S relocs (the latter being for signed
32 bit entities).  All instruction displacements have to use
the 32S variants.  Normal references like
  .long s
normally would use the _32 variant.  For normal executables this
doesn't matter.  For shared libraries neither (which use PC-relative
relocs).  But it matters for things like the kernel that are linked
to high addresses (signed ones).  There the GNU linker would error
out on overflow for the _32 variant.

To keep life simple we simply switch from _32 to _32S altogether.
Strictly speaking it's still wrong, but in practice using _32 is
more often wrong than using _32S ;)
This commit is contained in:
Michael Matz 2016-09-27 17:04:39 +02:00
parent ad8e14b740
commit 975c74c1f5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
x86_64-gen.c
View File

@ -242,7 +242,7 @@ ST_FUNC int oad(int c, int s)
ST_FUNC void gen_addr32(int r, Sym *sym, int c) ST_FUNC void gen_addr32(int r, Sym *sym, int c)
{ {
if (r & VT_SYM) if (r & VT_SYM)
greloca(cur_text_section, sym, ind, R_X86_64_32, c), c=0; greloca(cur_text_section, sym, ind, R_X86_64_32S, c), c=0;
gen_le32(c); gen_le32(c);
} }

2
x86_64-link.c
View File

@ -3,7 +3,7 @@
#define EM_TCC_TARGET EM_X86_64 #define EM_TCC_TARGET EM_X86_64
/* relocation type for 32 bit data relocation */ /* relocation type for 32 bit data relocation */
#define R_DATA_32 R_X86_64_32 #define R_DATA_32 R_X86_64_32S
#define R_DATA_PTR R_X86_64_64 #define R_DATA_PTR R_X86_64_64
#define R_JMP_SLOT R_X86_64_JUMP_SLOT #define R_JMP_SLOT R_X86_64_JUMP_SLOT
#define R_GLOB_DAT R_X86_64_GLOB_DAT #define R_GLOB_DAT R_X86_64_GLOB_DAT