github-repos/mirai
1
0
Fork 0
mirror of https://github.com/mamoe/mirai.git synced 2025-02-05 05:59:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

[core] Check service configuration when loading MessageProtocols. Helps #2268

Browse Source
This commit is contained in:
Him188 2022-10-12 14:49:52 +01:00
parent 4d80e0e6d3
commit 5ed9dc7e89
No known key found for this signature in database
GPG Key ID: BA439CDDCF652375
1 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
mirai-core/src/commonMain/kotlin/message/protocol/MessageProtocolFacade.kt
View File

@ -184,6 +184,12 @@ internal suspend fun MessageProtocolFacade.decodeAndRefineDeep(
): MessageChain = decode(elements, groupIdOrZero, messageSourceKind, bot).refineDeep(bot, refineContext) ): MessageChain = decode(elements, groupIdOrZero, messageSourceKind, bot).refineDeep(bot, refineContext)
private const val errorTips =
"This should not happen if you are using mirai under default JVM classloader or using Mirai Console." +
"If so, please file an issue. " +
"If you are trying to load mirai manually from other classloader, " +
"e.g. in another plugin system like Minecraft, it's your responsibility to ensure the Java SPI works."
internal class MessageProtocolFacadeImpl( internal class MessageProtocolFacadeImpl(
private val protocols: Iterable<MessageProtocol> = loadServices(MessageProtocol::class).asIterable(), private val protocols: Iterable<MessageProtocol> = loadServices(MessageProtocol::class).asIterable(),
override val remark: String = "MessageProtocolFacade" override val remark: String = "MessageProtocolFacade"
@ -197,6 +203,12 @@ internal class MessageProtocolFacadeImpl(
override val loaded: List<MessageProtocol> = kotlin.run { override val loaded: List<MessageProtocol> = kotlin.run {
val instances = protocols val instances = protocols
.sortedWith(MessageProtocol.PriorityComparator.reversed()) .sortedWith(MessageProtocol.PriorityComparator.reversed())
if (instances.isEmpty()) {
error(
"Failed to load services for MessageProtocol from your classpath. " +
"Check you ClassLoader environment and ensure services for '${MessageProtocol::class.qualifiedName}' can be loaded. $errorTips"
)
}
for (instance in instances) { for (instance in instances) {
instance.collectProcessors(object : ProcessorCollector() { instance.collectProcessors(object : ProcessorCollector() {
override fun <T : SingleMessage> add(encoder: MessageEncoder<T>, elementType: KClass<T>) { override fun <T : SingleMessage> add(encoder: MessageEncoder<T>, elementType: KClass<T>) {
@ -236,6 +248,14 @@ internal class MessageProtocolFacadeImpl(
instances.toList() instances.toList()
} }
private fun checkOutgoingPipeline() {
if (outgoingPipeline.processors.isEmpty()) {
error(
"`outgoingPipeline` is empty. It means you have corrupted classpath or bad service configuration. $errorTips"
)
}
}
override fun encode( override fun encode(
chain: MessageChain, chain: MessageChain,
messageTarget: ContactOrBot?, messageTarget: ContactOrBot?,
@ -309,13 +329,13 @@ internal class MessageProtocolFacadeImpl(
target: C, message: Message, target: C, message: Message,
components: ComponentStorage components: ComponentStorage
): MessageReceipt<C> { ): MessageReceipt<C> {
val attributes = createAttributesForOutgoingMessage(target, message, components) checkOutgoingPipeline()
val attributes = createAttributesForOutgoingMessage(target, message, components)
val (_, result) = outgoingPipeline.process(message.toMessageChain(), attributes) val (_, result) = outgoingPipeline.process(message.toMessageChain(), attributes)
return getSingleReceipt(result, message) return getSingleReceipt(result, message)
} }
override suspend fun <C : AbstractContact> preprocessAndSendOutgoing( override suspend fun <C : AbstractContact> preprocessAndSendOutgoing(
target: C, target: C,
message: Message, message: Message,
@ -331,6 +351,7 @@ internal class MessageProtocolFacadeImpl(
message: Message, message: Message,
components: ComponentStorage components: ComponentStorage
): ProcessResult<OutgoingMessagePipelineContext, MessageReceipt<*>> { ): ProcessResult<OutgoingMessagePipelineContext, MessageReceipt<*>> {
checkOutgoingPipeline()
val attributes = createAttributesForOutgoingMessage(target, message, components) val attributes = createAttributesForOutgoingMessage(target, message, components)
val data = message.toMessageChain() val data = message.toMessageChain()