github-repos/mirai
1
0
Fork 0
mirror of https://github.com/mamoe/mirai.git synced 2024-12-29 10:00:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

[core] Ensure Bot's CoroutineScope is always cancelled on Bot.close if network.close threw an exception

Browse Source
This commit is contained in:
Him188 2022-12-27 17:28:52 +00:00
parent 38162db477
commit 2252683cee
No known key found for this signature in database
GPG Key ID: BA439CDDCF652375
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
mirai-core/src/commonMain/kotlin/AbstractBot.kt
View File

@ -110,14 +110,16 @@ internal abstract class AbstractBot constructor(
override fun close(cause: Throwable?) {
if (!this.isActive) return
if (networkInitialized) {
network.close(cause)
}
if (cause == null) {
supervisorJob.cancel()
} else {
supervisorJob.cancel(CancellationException("Bot closed", cause))
try {
if (networkInitialized) {
network.close(cause)
}
} finally { // ensure CoroutineScope is always closed
if (cause == null) {
supervisorJob.cancel()
} else {
supervisorJob.cancel(CancellationException("Bot closed", cause))
}
}
}